fix usestdlibvars linter

Signed-off-by: Tim Ramlot <[email protected]>

Author: inteon

.golangci.yaml

@@ -18,7 +18,6 @@ linters:
           - noctx
           - predeclared
           - unparam
-          - usestdlibvars
         text: .*
     paths: [third_party$, builtin$, examples$]
     warn-unused: true

pkg/client/client_oauth.go

@@ -186,7 +186,7 @@ func (c *OAuthClient) renewAccessToken(ctx context.Context) error {
 	payload.Set("audience", audience)
 	payload.Set("username", c.credentials.UserID)
 	payload.Set("password", c.credentials.UserSecret)
-	req, err := http.NewRequestWithContext(ctx, "POST", tokenURL, strings.NewReader(payload.Encode()))
+	req, err := http.NewRequestWithContext(ctx, http.MethodPost, tokenURL, strings.NewReader(payload.Encode()))
 	if err != nil {
 		return errors.WithStack(err)
 	}

pkg/internal/cyberark/identity/identity.go

@@ -299,7 +299,7 @@ func (c *Client) doStartAuthentication(ctx context.Context, username string) (ad
 
 	defer httpResponse.Body.Close()
 
-	if httpResponse.StatusCode != 200 {
+	if httpResponse.StatusCode != http.StatusOK {
 		err := fmt.Errorf("got unexpected status code %s from request to start authentication in CyberArk Identity API", httpResponse.Status)
 		if httpResponse.StatusCode >= 500 || httpResponse.StatusCode < 400 {
 			return response, err
@@ -410,7 +410,7 @@ func (c *Client) doAdvanceAuthentication(ctx context.Context, username string, p
 
 	// Important: Even login failures can produce a 200 status code, so this
 	// check won't catch all failures
-	if httpResponse.StatusCode != 200 {
+	if httpResponse.StatusCode != http.StatusOK {
 		err := fmt.Errorf("got unexpected status code %s from request to advance authentication in CyberArk Identity API", httpResponse.Status)
 		if httpResponse.StatusCode >= 500 || httpResponse.StatusCode < 400 {
 			return err

pkg/internal/cyberark/servicediscovery/discovery.go

@@ -97,10 +97,10 @@ func (c *Client) DiscoverIdentityAPIURL(ctx context.Context, subdomain string) (
 
 	defer resp.Body.Close()
 
-	if resp.StatusCode != 200 {
+	if resp.StatusCode != http.StatusOK {
 		// a 404 error is returned with an empty JSON body "{}" if the subdomain is unknown; at the time of writing, we haven't observed
 		// any other errors and so we can't special case them
-		if resp.StatusCode == 404 {
+		if resp.StatusCode == http.StatusNotFound {
 			return "", fmt.Errorf("got an HTTP 404 response from service discovery; maybe the subdomain %q is incorrect or does not exist?", subdomain)
 		}