Remove debugging transport and enable e2e log-level

Because venafi-connection-lib 0.5.1 includes the debugging roundtripper as part
of the default client.
Added debug logging to the ark-test-e2e so that I can see the debug logging
still working.

- Remove debug roundtripper from agent HTTP client
- Drop import of k8s.io/client-go/transport
- Enable verbose logging in e2e helm chart (set --log-level=6)

Signed-off-by: Richard Wall <[email protected]>

Author: wallrj-cyberark

hack/ark/test-e2e.sh

@@ -71,6 +71,7 @@ helm upgrade agent "oci://${ARK_CHART}@${ARK_CHART_DIGEST}" \
      --wait \
      --create-namespace \
      --namespace "$NAMESPACE" \
+     --set-json extraArgs='["--log-level=6"]' \
      --set pprof.enabled=true \
      --set fullnameOverride=disco-agent \
      --set "image.digest=${ARK_IMAGE_DIGEST}" \

pkg/agent/config.go

@@ -15,7 +15,6 @@ import (
 	"github.com/spf13/cobra"
 	"gopkg.in/yaml.v3"
 	"k8s.io/client-go/rest"
-	"k8s.io/client-go/transport"
 
 	"github.com/jetstack/preflight/api"
 	"github.com/jetstack/preflight/pkg/client"
@@ -815,7 +814,6 @@ func validateCredsAndCreateClient(log logr.Logger, flagCredentialsPath, flagClie
 			rootCAs *x509.CertPool
 		)
 		httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs)
-		httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext)
 		outputClient, err = client.NewCyberArk(httpClient)
 		if err != nil {
 			errs = multierror.Append(errs, err)