Skip to content

Commit eb56c74

Browse files
committed
feat: make the registry a var and therefore configurable
Signed-off-by: Peter Fiddes <[email protected]>
1 parent e3b13de commit eb56c74

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

deploy/charts/jetstack-agent/README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,13 @@ To validate you registry credentials are working with `helm`, we can use it to
4040
show us the full list of values available to configure the chart:
4141

4242
```shell
43-
helm show values oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent --registry-config "${TLSPK_DOCKER_CONFIG_FILE}"
43+
export TLSPK_REGISTRY="eu.gcr.io/jetstack-secure-enterprise"
44+
helm show values oci://${TLSPK_REGISTRY}/charts/jetstack-agent --registry-config "${TLSPK_DOCKER_CONFIG_FILE}"
4445
```
4546

47+
**Note**: Feel free to alter the registry to the US equivalent if that is closer
48+
to you, for example: `export TLSPK_REGISTRY="us.gcr.io/jetstack-secure-enterprise"`
49+
4650
### 2) Obtaining TLSPK agent credentials:
4751

4852
Set the following environments variables for ease of installation:
@@ -81,7 +85,7 @@ Install the chart with the basic configuration:
8185

8286
```shell
8387
helm upgrade --install --create-namespace -n jetstack-secure jetstack-agent \
84-
oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent \
88+
oci://${TLSPK_REGISTRY}/charts/jetstack-agent \
8589
--registry-config "${TLSPK_DOCKER_CONFIG_FILE}" \
8690
--set config.organisation="${TLSPK_ORG}" \
8791
--set config.cluster="${TLSPK_CLUSTER_NAME}"
@@ -100,7 +104,7 @@ credential, read from the environment variable just set:
100104

101105
```shell
102106
helm upgrade --install --create-namespace -n jetstack-secure jetstack-agent \
103-
oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent \
107+
oci://${TLSPK_REGISTRY}/charts/jetstack-agent \
104108
--registry-config "${TLSPK_DOCKER_CONFIG_FILE}" \
105109
--set config.organisation="${TLSPK_ORG}" \
106110
--set config.cluster="${TLSPK_CLUSTER_NAME}" \

deploy/charts/jetstack-agent/README.md.gotmpl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@ To validate you registry credentials are working with `helm`, we can use it to
3939
show us the full list of values available to configure the chart:
4040

4141
```shell
42-
helm show values oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent --registry-config "${TLSPK_DOCKER_CONFIG_FILE}"
42+
export TLSPK_REGISTRY="eu.gcr.io/jetstack-secure-enterprise"
43+
helm show values oci://${TLSPK_REGISTRY}/charts/jetstack-agent --registry-config "${TLSPK_DOCKER_CONFIG_FILE}"
4344
```
4445

46+
**Note**: Feel free to alter the registry to the US equivalent if that is closer
47+
to you, for example: `export TLSPK_REGISTRY="us.gcr.io/jetstack-secure-enterprise"`
48+
4549
### 2) Obtaining TLSPK agent credentials:
4650

4751
Set the following environments variables for ease of installation:
@@ -80,7 +84,7 @@ Install the chart with the basic configuration:
8084

8185
```shell
8286
helm upgrade --install --create-namespace -n jetstack-secure jetstack-agent \
83-
oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent \
87+
oci://${TLSPK_REGISTRY}/charts/jetstack-agent \
8488
--registry-config "${TLSPK_DOCKER_CONFIG_FILE}" \
8589
--set config.organisation="${TLSPK_ORG}" \
8690
--set config.cluster="${TLSPK_CLUSTER_NAME}"
@@ -99,7 +103,7 @@ credential, read from the environment variable just set:
99103

100104
```shell
101105
helm upgrade --install --create-namespace -n jetstack-secure jetstack-agent \
102-
oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent \
106+
oci://${TLSPK_REGISTRY}/charts/jetstack-agent \
103107
--registry-config "${TLSPK_DOCKER_CONFIG_FILE}" \
104108
--set config.organisation="${TLSPK_ORG}" \
105109
--set config.cluster="${TLSPK_CLUSTER_NAME}" \

0 commit comments

Comments
 (0)