Skip to content

Commit ebcf00b

Browse files
author
Mladen Rusev
committed
update the type of tenant_flags to accommodate actual boolean values; update readme and envrc.template
1 parent 6134f1a commit ebcf00b

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

.envrc.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export CLOUDSDK_COMPUTE_ZONE= # the GCP zone where a GKE cluster will be created
1414
export CLUSTER_NAME= # the name of the GKE cluster which will be created. E.g. cluster-1
1515

1616
# The following variables are required for CyberArk / MachineHub integration tests.
17-
export ARK_SUBDOMAIN= # your CyberArk tenant subdomain
17+
export ARK_SUBDOMAIN= # your CyberArk tenant subdomain e.g. tlskp-test
1818
export ARK_USERNAME= # your CyberArk username
1919
export ARK_SECRET= # your CyberArk password
2020
# OPTIONAL: the URL for the CyberArk Discovery API if not using the production environment

pkg/internal/cyberark/servicediscovery/discovery.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,14 @@ func New(httpClient *http.Client) *Client {
5757
// DiscoveryResponse represents the full JSON response returned by the CyberArk api/tenant-discovery/public API
5858
// The API is documented here https://ca-il-confluence.il.cyber-ark.com/spaces/EV/pages/575618345/Updated+PD+APIs+doc
5959
type DiscoveryResponse struct {
60-
Region string `json:"region"`
61-
DRRegion string `json:"dr_region"`
62-
Subdomain string `json:"subdomain"`
63-
PlatformID string `json:"platform_id"`
64-
IdentityID string `json:"identity_id"`
65-
DefaultURL string `json:"default_url"`
66-
TenantFlags map[string]string `json:"tenant_flags"`
67-
Services []Service `json:"services"`
60+
Region string `json:"region"`
61+
DRRegion string `json:"dr_region"`
62+
Subdomain string `json:"subdomain"`
63+
PlatformID string `json:"platform_id"`
64+
IdentityID string `json:"identity_id"`
65+
DefaultURL string `json:"default_url"`
66+
TenantFlags map[string]interface{} `json:"tenant_flags"`
67+
Services []Service `json:"services"`
6868
}
6969

7070
type Service struct {

pkg/internal/cyberark/servicediscovery/testdata/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ To get the original data:
66

77
NOTE: This API is not implemented yet as of 02.09.2025 but is expected to be finalised by end of PI3 2025.
88
```bash
9-
curl -fsSL "${ARK_DISCOVERY_API}/api/public/tenant-discovery?bySubdomain=${ARK_SUBDOMAIN}" | jq
9+
curl -fsSL "${ARK_DISCOVERY_API}?bySubdomain=${ARK_SUBDOMAIN}" | jq
1010
```
1111

1212
Then replace `identity_administration.api` with `{{ .Identity.API }}` and

0 commit comments

Comments
 (0)