Skip to content

Commit f3431e6

Browse files
committed
wip: temp: fix govulncheck
Signed-off-by: Ashley Davis <[email protected]>
1 parent e6f1925 commit f3431e6

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

klone.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ targets:
1313
repo_hash: 684d99b0a6378fb3625c188bc5a0081ae9d2bbdc
1414
repo_path: modules/generate-verify
1515
- folder_name: go
16-
repo_url: https://github.com/cert-manager/makefile-modules.git
17-
repo_ref: main
18-
repo_hash: 684d99b0a6378fb3625c188bc5a0081ae9d2bbdc
16+
repo_url: https://github.com/SgtCoDFish/cert-manager-makefile-modules.git
17+
repo_ref: govulncheck-goprivate
18+
repo_hash: b341741b2ef923b257763d809cb30e8bac512f32
1919
repo_path: modules/go
2020
- folder_name: helm
2121
repo_url: https://github.com/cert-manager/makefile-modules.git

make/00_mod.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ helm_chart_version := $(VERSION)
4343
helm_labels_template_name := preflight.labels
4444

4545
govulncheck_generate_org := jetstack
46+
govulncheck_goprivate := github.com/jetstack/venafi-connection-lib
4647

4748
# Allows us to replace the Helm values.yaml's image.repository and image.tag
4849
# with the right values.

make/_shared/go/01_mod.mk

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ generate-go-mod-tidy: | $(NEEDS_GO)
5858
shared_generate_targets += generate-go-mod-tidy
5959

6060
default_govulncheck_generate_base_dir := $(dir $(lastword $(MAKEFILE_LIST)))/base/
61+
6162
# The base directory used to copy the govulncheck GH action from. This can be
6263
# overwritten with an action with extra authentication or with a totally different
6364
# pipeline (eg. a GitLab pipeline).
@@ -67,6 +68,10 @@ govulncheck_generate_base_dir ?= $(default_govulncheck_generate_base_dir)
6768
# being run on every fork of the repo.
6869
govulncheck_generate_org ?= cert-manager
6970

71+
# Any closed-source or inaccessible Go modules that should be ignored by govulncheck; not needed
72+
# for most open-source projects.
73+
govulncheck_goprivate ?=
74+
7075
.PHONY: generate-govulncheck
7176
## Generate base files in the repository
7277
## @category [shared] Generate/ Verify
@@ -96,7 +101,7 @@ verify-govulncheck: | $(NEEDS_GOVULNCHECK)
96101
target=$$(dirname $${d}); \
97102
echo "Running 'GOTOOLCHAIN=go$(VENDORED_GO_VERSION) $(bin_dir)/tools/govulncheck ./...' in directory '$${target}'"; \
98103
pushd "$${target}" >/dev/null; \
99-
GOTOOLCHAIN=go$(VENDORED_GO_VERSION) $(GOVULNCHECK) ./... || exit; \
104+
GOPRIVATE=$(govulncheck_goprivate) GOTOOLCHAIN=go$(VENDORED_GO_VERSION) $(GOVULNCHECK) ./... || exit; \
100105
popd >/dev/null; \
101106
echo ""; \
102107
done

0 commit comments

Comments
 (0)