Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit 5762ae9

Browse files
committed
Update values to remove confusing extra headers, and add note that
client IP may not be the real client IP Signed-off-by: JoshVanL <[email protected]>
1 parent d73c2f2 commit 5762ae9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

deploy/charts/kube-oidc-proxy/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ tokenPassthrough:
5858
# https://github.com/jetstack/kube-oidc-proxy/blob/master/docs/tasks/extra-impersonation-headers.md
5959
extraImpersonationHeaders:
6060
clientIP: false
61-
headers: #{}
6261
#headers: key1=foo,key2=bar,key1=bar
6362

6463

docs/tasks/extra-impersonation-headers.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ extra header:
1414

1515
Proxied requests will then contain the header
1616
`Impersonate-Extra-Remote-Client-Ip: <REMOTE_ADDR>` where `<REMOTE_ADDR>` is
17-
the address of the client that made the request.
17+
the address of the source connection of the request. Note that this IP address
18+
may not be the real client IP address when the request is being proxied.
1819

1920
# Extra User Headers
2021

0 commit comments

Comments
 (0)