Merge pull request #157 from JoshVanL/readiness-expected-error

jetstack-bot · web-flow · commit 75442f9f5711 · 2020-06-29T14:59:26.000+01:00
Change probe readiness log output to be less confusing for happy path
diff --git a/pkg/probe/probe.go b/pkg/probe/probe.go
@@ -66,8 +66,8 @@ func (h *HealthCheck) Check() error {
 
 	h.ready = true
 
+	klog.V(4).Infof("OIDC provider initialized, readiness check returned expected error: %s", err)
 	klog.Info("OIDC provider initialized, proxy ready")
-	klog.V(4).Infof("OIDC provider initialized, readiness check returned error: %s", err)
 
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ func (h *HealthCheck) Check() error {`
`66`	`66`
`67`	`67`	`h.ready = true`
`68`	`68`
	`69`	`+ klog.V(4).Infof("OIDC provider initialized, readiness check returned expected error: %s", err)`
`69`	`70`	`klog.Info("OIDC provider initialized, proxy ready")`
`70`		`- klog.V(4).Infof("OIDC provider initialized, readiness check returned error: %s", err)`
`71`	`71`
`72`	`72`	`return nil`
`73`	`73`	`}`