Adds e2e test to test proxy readiness probe

Signed-off-by: JoshVanL <[email protected]>

Author: JoshVanL

pkg/probe/probe.go

@@ -11,7 +11,6 @@ import (
 
 	"github.com/heptiolabs/healthcheck"
 	"k8s.io/apiserver/pkg/authentication/authenticator"
-	//"k8s.io/apiserver/pkg/authentication/request/bearertoken"
 	"k8s.io/klog"
 )
 

test/e2e/framework/helper/deploy.go

@@ -67,7 +67,7 @@ func (h *Helper) DeployProxy(ns *corev1.Namespace, issuerURL, clientID string,
 					Port: intstr.FromInt(8080),
 				},
 			},
-			InitialDelaySeconds: 9,
+			InitialDelaySeconds: 1,
 			PeriodSeconds:       3,
 		},
 	}

test/e2e/suite/cases/doc.go

@@ -4,6 +4,7 @@ package cases
 import (
 	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/impersonation"
 	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/passthrough"
+	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/probe"
 	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/rbac"
 	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/token"
 	_ "github.com/jetstack/kube-oidc-proxy/test/e2e/suite/cases/upgrade"

test/e2e/suite/cases/probe/probe.go

@@ -0,0 +1,40 @@
+// Copyright Jetstack Ltd. See LICENSE for details.
+package probe
+
+import (
+	"time"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	"github.com/jetstack/kube-oidc-proxy/test/e2e/framework"
+	"github.com/jetstack/kube-oidc-proxy/test/e2e/framework/helper"
+)
+
+var _ = framework.CasesDescribe("Readiness Probe", func() {
+	f := framework.NewDefaultFramework("readiness-probe")
+
+	It("Should not become ready if the issuer is unavailable", func() {
+		By("Deleting the Issuer so no longer becomes reachable")
+		Expect(f.Helper().DeleteIssuer(f.Namespace.Name)).NotTo(HaveOccurred())
+
+		By("Deleting the current proxy that is ready")
+		Expect(f.Helper().DeleteProxy(f.Namespace.Name)).NotTo(HaveOccurred())
+
+		By("Deploying the Proxy should never become ready as the issuer is unavailable")
+		_, _, err := f.Helper().DeployProxy(f.Namespace, f.IssuerURL(),
+			f.ClientID(), f.IssuerKeyBundle())
+		// Error should occur (not ready)
+		Expect(err).To(HaveOccurred())
+	})
+
+	It("Should continue to be ready even if the issuer becomes unavailable", func() {
+		By("Deleting the Issuer so no longer becomes reachable")
+		Expect(f.Helper().DeleteIssuer(f.Namespace.Name)).NotTo(HaveOccurred())
+
+		time.Sleep(time.Second * 10)
+
+		err := f.Helper().WaitForPodReady(f.Namespace.Name, helper.ProxyName, time.Second*5)
+		Expect(err).NotTo(HaveOccurred())
+	})
+})