Only error when dynamic auditing flag is set to true

Signed-off-by: JoshVanL <[email protected]>

Author: JoshVanL

cmd/app/options/audit.go

@@ -2,7 +2,6 @@
 package options
 
 import (
-	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	apiserveroptions "k8s.io/apiserver/pkg/server/options"
 	cliflag "k8s.io/component-base/cli/flag"
@@ -24,11 +23,3 @@ func (a *AuditOptions) AddFlags(fs *pflag.FlagSet) *AuditOptions {
 	a.AuditOptions.AddFlags(fs)
 	return a
 }
-
-func (a *AuditOptions) DynamicConfigurationFlagChanged(cmd *cobra.Command) bool {
-	if ff := cmd.Flag("audit-dynamic-configuration"); ff != nil && ff.Changed {
-		return true
-	}
-
-	return false
-}

cmd/app/options/options.go

@@ -91,7 +91,7 @@ func (o *Options) Validate(cmd *cobra.Command) error {
 		errs = append(errs, errors.New("cannot add extra user headers when impersonation disabled"))
 	}
 
-	if o.Audit.DynamicConfigurationFlagChanged(cmd) {
+	if o.Audit.DynamicOptions.Enabled {
 		errs = append(errs, errors.New("The flag --audit-dynamic-configuration may not be set"))
 	}