feat: Reflect Comments

Author: joshw123

cmd/inspect.go

@@ -48,7 +48,7 @@ Partial certificates are also all printed for further inspection.
 				return err
 			}
 
-			analyser, err := analyse.NewAnalyser(analyseOpts.MozillaRemovedCertsURL)
+			analyser, err := analyse.NewAnalyser(analyseOpts)
 			if err != nil {
 				return errors.Wrap(err, "failed to initialise analyser")
 			}

internal/analyse/analyse.go

@@ -11,6 +11,7 @@ import (
 	"time"
 
 	"github.com/hako/durafmt"
+	"github.com/jetstack/paranoia/cmd/options"
 )
 
 type NoteLevel string
@@ -36,22 +37,23 @@ type Analyser struct {
 	RemovedCertificates []removedCertificate
 }
 
+const defaultMozillaRemovedCACertificateReportURL = "https://ccadb.my.salesforce-sites.com/mozilla/RemovedCACertificateReportCSVFormat"
+
 // NewAnalyser creates a new Analyzer using the public Mozilla CA removed certificate list as part of
 // its checks. This method performs HTTP requests to retrieve that list. The request will be made with the given
-// context. If mozillaRemovedCertsURL is empty, the default Mozilla URL will be used.
-func NewAnalyser(mozillaRemovedCertsURL string) (*Analyser, error) {
-	rc, err := downloadMozillaRemovedCACertsList(mozillaRemovedCertsURL)
+// context. The options struct configures various aspects of the analysis.
+func NewAnalyser(opts *options.Analyse) (*Analyser, error) {
+	rc, err := downloadMozillaRemovedCACertsList(opts)
 	if err != nil {
 		return nil, err
 	}
 	return &Analyser{RemovedCertificates: rc}, nil
 }
 
-func downloadMozillaRemovedCACertsList(mozillaRemovedCertsURL string) ([]removedCertificate, error) {
-	const defaultMozillaRemovedCACertificateReportURL = "https://ccadb.my.salesforce-sites.com/mozilla/RemovedCACertificateReportCSVFormat"
+func downloadMozillaRemovedCACertsList(opts *options.Analyse) ([]removedCertificate, error) {
 
 	// Use default URL if none provided
-	url := mozillaRemovedCertsURL
+	url := opts.MozillaRemovedCertsURL
 	if url == "" {
 		url = defaultMozillaRemovedCACertificateReportURL
 	}