Make the selfhosting API Cleaner

Author: David Collom

pkg/client/selfhosted/api_types.go

@@ -45,6 +45,14 @@ func (v *V1CompatibilityWrapper) UnmarshalJSON(b []byte) error {
 	return json.Unmarshal([]byte(raw), &v.V1Compatibility)
 }
 
+func (v V1CompatibilityWrapper) MarshalJSON() ([]byte, error) {
+	marshaled, err := json.Marshal(v.V1Compatibility)
+	if err != nil {
+		return nil, err
+	}
+	return json.Marshal(string(marshaled)) // ← Double encode: inner to string
+}
+
 type ErrorResponse struct {
 	Errors []ErrorType `json:"errors"`
 }

pkg/client/selfhosted/selfhosted.go

@@ -227,10 +227,6 @@ func (c *Client) Tags(ctx context.Context, host, repo, image string) ([]api.Imag
 			tags[tag] = current
 		}
 
-		if len(manifestListResponse.Manifests) == 0 {
-			// TODO:
-		}
-
 		for _, manifest := range manifestListResponse.Manifests {
 
 			// If we didn't get a SHA from the inital call,

pkg/client/selfhosted/selfhosted_test.go

@@ -144,7 +144,7 @@ func TestTags(t *testing.T) {
 					History: []History{
 						{
 							V1Compatibility: V1CompatibilityWrapper{
-								V1Compatibility{Created: time.Now().Add(-24 * time.Hour)},
+								V1Compatibility: V1Compatibility{Created: time.Now()},
 							},
 						},
 					},