[BUG] Grafana dashboard doesn't load data by default if already existing Prometheus and Grafana are used

[abdullahkhawer]

Describe the bug
After deploying version-checker using Helm as described in the README.md as follows:

helm repo add jetstack https://charts.jetstack.io
helm install version-checker jetstack/version-checker

And after installing the Grafana dashboard, I wasn't able to see any data.

To Reproduce
Steps to reproduce the behavior:

• Simply deploy the version-checker using Helm on your existing Kubernetes cluster having prometheus and grafana deployments with default configurations. In my case, it was kube-prometheus-stack Helm chart.

Expected behavior
Everything should work by default and we should be able to see data on the Grafana dashboard.

Environment (please complete the following information):

• Version-Checker: v0.8.3
• Kubernetes: v1.18.6
• Grafana: v11.3.0
• Prometheus: v2.55.1

Solution
After doing some troubleshooting, I realised that the service monitor for version-checker metrics was missing under the monitoring.coreos.com CRD. After setting serviceMonitor.enabled to true in the default values of Helm release of version-checker, it started working and I was able to see data on the Grafana dashboard. Of course, a service monitor is a requirement for it to work.

So, I think it should be enabled by default so it works for those who already have a promethues and grafana instances. Otherwise, the README.md should be updated with this configuration details so the new users don't get confused.

[davidcollom]

this was resolved in #320