Skip to content

Commit 6a9b361

Browse files
committed
cleanup tests
1 parent ac9fcc5 commit 6a9b361

14 files changed

+21
-22
lines changed

test/support/hugo_helpers.rb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ def initialize(path: nil, port: nil)
1010
end
1111

1212
HUGO_OPTIONS = %w[
13+
hugo
1314
--environment test
1415
--buildDrafts
1516
--logLevel warn
@@ -25,14 +26,12 @@ def precompile(port:)
2526

2627
port ||= @port
2728

28-
base_url_option = port ? "--baseURL=\"http://localhost:#{port}\"" : ""
29-
30-
options = HUGO_OPTIONS.join(" ")
31-
hugo_build_cmd = "hugo #{options} #{base_url_option} --destination=\"#{destination}\"".strip
32-
33-
warn "Hugo: #{hugo_build_cmd}" if ENV["DEBUG"]
34-
35-
system(hugo_build_cmd, exception: true)
29+
# Build hugo command using argv array to avoid shell quoting issues
30+
args = HUGO_OPTIONS.dup
31+
args += %W[--baseURL http://localhost:#{port}] if port
32+
args += %W[--destination #{destination}]
33+
warn "Hugo: #{args.join(' ')}" if ENV["DEBUG"]
34+
system(*args, exception: true)
3635
self
3736
end
3837

test/unit/asset_url_validation_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "base_page_test"
22

3-
class AssetUrlValidationTest < BasePageTest
3+
class AssetUrlValidationTest < BasePageTestCase
44
DEFAULT_TEST_HTML_FILE = '404.html'
55

66

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# Build Hugo without baseURL for unit tests (they don't need specific ports)
77
Hugo.new.precompile(port: nil)
88

9-
class BasePageTest < Minitest::Test
9+
class BasePageTestCase < Minitest::Test
1010
private
1111

1212
def root_path

test/unit/diagram_rendering_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "base_page_test"
22

3-
class DiagramRenderingTest < BasePageTest
3+
class DiagramRenderingTest < BasePageTestCase
44
# Unit tests for diagram rendering functionality (Mermaid support)
55
# Tests rendered HTML output from public-test directory (no server required)
66

test/unit/hugo_asset_validation_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "base_page_test"
22

3-
class HugoAssetValidationTest < BasePageTest
3+
class HugoAssetValidationTest < BasePageTestCase
44
EXPECTED_HOST = "localhost"
55

66
# Asset pattern constants
@@ -104,4 +104,4 @@ def test_no_hardcoded_production_urls
104104
assert_empty hardcoded_assets.map { |a| a["href"] || a["src"] },
105105
"Should not have hardcoded production asset URLs"
106106
end
107-
end
107+
end

test/unit/hugo_partials_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "base_page_test"
22

3-
class HugoPartialsTest < BasePageTest
3+
class HugoPartialsTest < BasePageTestCase
44
# Unit tests for Hugo partial templates functionality and rendering
55
# Tests rendered HTML output from public-test directory (no server required)
66

test/unit/meta_tags/article_schema_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "../base_page_test"
22

3-
class ArticleSchemaTest < BasePageTest
3+
class ArticleSchemaTest < BasePageTestCase
44
def test_blog_post_has_article_schema
55
doc = parse_html_file("blog/devtools-for-ai-agents/index.html")
66
schemas = find_schemas_by_type(doc, "Article")

test/unit/meta_tags/breadcrumb_schema_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "../base_page_test"
22

3-
class BreadcrumbSchemaTest < BasePageTest
3+
class BreadcrumbSchemaTest < BasePageTestCase
44
def test_blog_post_has_breadcrumb_list_schema
55
doc = parse_html_file("blog/4-lines-speed-up-your-rails-test-suite-on-circleci/index.html")
66
schemas = find_schemas_by_type(doc, "BreadcrumbList")

test/unit/meta_tags/meta_tags_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "../base_page_test"
22

3-
class MetaTagsTest < BasePageTest
3+
class MetaTagsTest < BasePageTestCase
44
# Unit tests for meta tags functionality and SEO validation
55
# Tests rendered HTML output from public-test directory (no server required)
66

test/unit/meta_tags/organization_schema_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require_relative "../base_page_test"
22

3-
class OrganizationSchemaTest < BasePageTest
3+
class OrganizationSchemaTest < BasePageTestCase
44
def test_organization_schema_exists
55
doc = parse_html_file("about-us/index.html")
66
schemas = find_schemas_by_type(doc, "Organization")

0 commit comments

Comments
 (0)