Skip to content

Commit 1021d9d

Browse files
authored
fixt test (#79)
Signed-off-by: Olivier Lamy <[email protected]>
1 parent 96cb3c3 commit 1021d9d

File tree

5 files changed

+28
-18
lines changed

5 files changed

+28
-18
lines changed

src/it/filtering-it/pom.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<nonFilteredFileExtension>tga</nonFilteredFileExtension>
3434
<nonFilteredFileExtension>zip</nonFilteredFileExtension>
3535
<nonFilteredFileExtension>gz</nonFilteredFileExtension>
36-
<nonFilteredFileExtension>tif</nonFilteredFileExtension>
36+
<nonFilteredFileExtension>gif</nonFilteredFileExtension>
3737
<nonFilteredFileExtension>tiff</nonFilteredFileExtension>
3838
<nonFilteredFileExtension>svgz</nonFilteredFileExtension>
3939
<nonFilteredFileExtension>jp2</nonFilteredFileExtension>
@@ -72,6 +72,10 @@
7272
<filtering>true</filtering>
7373
<directory>src/main/config</directory>
7474
</resource>
75+
<resource>
76+
<filtering>true</filtering>
77+
<directory>src/main/webapp</directory>
78+
</resource>
7579
</resources>
7680
</configuration>
7781
</execution>
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<%@ page contentType="text/html; charset=UTF-8" %>
2+
<%@ page import="jakarta.servlet.http.HttpSession"%>
3+
<html>
4+
<head>
5+
<title>Logout</title>
6+
</head>
7+
8+
<body>
9+
<%
10+
HttpSession s = request.getSession(false);
11+
s.invalidate();
12+
%>
13+
<h1>Logout</h1>
14+
15+
<p>You are now logged out.</p>
16+
<a href="/"/>Home</a>
17+
</body>
18+
19+
</html>
4.67 KB
Loading

src/it/filtering-it/verify.groovy

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,9 @@ assert !source.text.contains( 'web-app_5_0.xsd')
88
assert source.text.contains( 'org.eclipse.jetty.ee8.plus.webapp.PlusDescriptorProcessorTest$TestInjections');
99
assert source.text.contains( 'javax.servlet.Foo');
1010

11+
File jsp = new File( basedir, "target/test-classes/logout.jsp" );
12+
assert jsp.isFile()
13+
assert !jsp.text.contains( 'jakarta')
14+
1115

1216

src/main/java/org/eclipse/jetty/toolchain/modifysources/ResourcesFiltering.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,6 @@ public ResourcesFiltering(MavenFileFilter mavenFileFilter, BuildContext buildCon
4141
super(new JettyMavenFileFilter(buildContext), buildContext);
4242
}
4343

44-
@Override
45-
public boolean filteredFileExtension(String fileName, List<String> userNonFilteredFileExtensions) {
46-
String ext = getExtension(fileName);
47-
return ext == null? false : Arrays.asList("xml", "properties", "txt").contains(ext);
48-
}
49-
50-
private static String getExtension( String fileName )
51-
{
52-
String rawExt = FilenameUtils.getExtension(fileName);
53-
return rawExt == null ? null : rawExt.toLowerCase(Locale.ROOT);
54-
}
55-
56-
@Override
57-
public void filterResources(MavenResourcesExecution mavenResourcesExecution) throws MavenFilteringException {
58-
super.filterResources(mavenResourcesExecution);
59-
}
60-
6144
public static class JettyMavenFileFilter extends DefaultMavenFileFilter implements MavenFileFilter {
6245

6346
private BuildContext buildContext;

0 commit comments

Comments
 (0)