fixing hugging face test

Author: nitinp19

services/build.gradle

@@ -42,16 +42,4 @@ artifacts {
     archives sourcesJar,
             javadocJar,
             jar
-}
-
-test {
-    useTestNG()
-    testLogging {
-        events "passed", "skipped", "failed", "standardOut", "standardError"
-        showStandardStreams = true
-        exceptionFormat = "full"
-        showStackTraces = true
-        showCauses = true
-    }
-    outputs.upToDateWhen { false }
-}
+}

services/src/main/java/org/jfrog/artifactory/client/impl/jackson/RepositorySettingsMixIn.java

@@ -46,8 +46,7 @@
     @JsonSubTypes.Type(value = CargoRepositorySettingsImpl.class, name = "cargo"),
     @JsonSubTypes.Type(value = TerraformRepositorySettingsImpl.class, name = "terraform"),
     @JsonSubTypes.Type(value = OciRepositorySettingsImpl.class, name = "oci"),
-    @JsonSubTypes.Type(value = HuggingFaceRepositorySettingsImpl.class, name = "huggingfaceml"),
-    @JsonSubTypes.Type(value = HuggingFaceRepositorySettingsImpl.class, name = "HuggingFaceML")
+    @JsonSubTypes.Type(value = HuggingFaceRepositorySettingsImpl.class, name = "huggingfaceml")
 })
 
 public abstract class RepositorySettingsMixIn {

services/src/main/resources/artifactory.client.release.properties

@@ -1 +1,2 @@
 version=2.20.1
+

services/src/test/groovy/org/jfrog/artifactory/client/HuggingFacePackageTypeRepositoryTest.java

@@ -1,9 +1,11 @@
 package org.jfrog.artifactory.client;
 
 import org.jfrog.artifactory.client.model.Repository;
+import org.jfrog.artifactory.client.model.RepositoryType;
 import org.jfrog.artifactory.client.model.builder.RepositoryBuilders;
 import org.jfrog.artifactory.client.model.impl.PackageTypeImpl;
 import org.jfrog.artifactory.client.model.repository.settings.HuggingFaceRepositorySettings;
+import org.jfrog.artifactory.client.model.repository.settings.RepositorySettings;
 import org.jfrog.artifactory.client.model.repository.settings.impl.HuggingFaceRepositorySettingsImpl;
 import org.testng.annotations.AfterMethod;
 import org.testng.SkipException;
@@ -27,9 +29,13 @@ private void cleanup() {
         deleteRepoIfExists(virtualRepo);
     }
 
+    @Override
+    public RepositorySettings getRepositorySettings(RepositoryType repositoryType) {
+        return new HuggingFaceRepositorySettingsImpl();
+    }
+
     @Test
     public void testHuggingFaceLocalRepo() {
-        System.err.println("=== [DIAG] Starting testHuggingFaceLocalRepo ===");
         printEnvironmentDiagnostics();
 
         HuggingFaceRepositorySettings settings = new HuggingFaceRepositorySettingsImpl();
@@ -43,17 +49,7 @@ public void testHuggingFaceLocalRepo() {
 
         // Use position 0 for create, as required by the interface
         String localCreateResult = artifactory.repositories().create(0, localRepository);
-        System.err.println("[DIAG] create(local) result: " + localCreateResult);
-        printRepositoryJson(localRepo);
-        
         Repository localRepoFromServer = artifactory.repository(localRepo).get();
-        System.err.println("[DIAG] Retrieved repo package type: " + localRepoFromServer.getRepositorySettings().getPackageType());
-        
-        // Check if server doesn't support HuggingFace and skip if so
-        if (localRepoFromServer.getRepositorySettings().getPackageType().toString().equals("generic")) {
-            System.err.println("[DIAG] Server returned generic package type - skipping test");
-            throw new SkipException("Server returned packageType=generic for Hugging Face; likely unsupported on this instance.");
-        }
 
         assertNotNull(localRepoFromServer);
         assertEquals(localRepoFromServer.getKey(), localRepo);
@@ -75,9 +71,6 @@ public void testHuggingFaceFederatedRepo() {
                 .build();
 
         String federatedCreateResult = artifactory.repositories().create(0, federatedRepository);
-        System.out.println("[DIAG] create(federated) result: " + federatedCreateResult);
-        printEnvironmentDiagnostics();
-        printRepositoryJson(federatedRepo);
         Repository federatedRepoFromServer = artifactory.repository(federatedRepo).get();
         assertNotNull(federatedRepoFromServer);
         assertEquals(federatedRepoFromServer.getKey(), federatedRepo);
@@ -87,9 +80,6 @@ public void testHuggingFaceFederatedRepo() {
 
     @Test
     public void testHuggingFaceVirtualRepo() {
-        System.err.println("=== [DIAG] Starting testHuggingFaceVirtualRepo ===");
-        printEnvironmentDiagnostics();
-        
         HuggingFaceRepositorySettings settings = new HuggingFaceRepositorySettingsImpl();
         RepositoryBuilders repositoryBuilders = artifactory.repositories().builders();
         // Ensure we have at least one backing repo to include in the virtual
@@ -107,55 +97,11 @@ public void testHuggingFaceVirtualRepo() {
                 .repositorySettings(settings)
                 .repositories(java.util.Collections.singletonList(localRepo))
                 .build();
-
-        try {
-            String virtualCreateResult = artifactory.repositories().create(0, virtualRepository);
-            System.err.println("[DIAG] create(virtual) result: " + virtualCreateResult);
-            printRepositoryJson(virtualRepo);
 
             Repository virtualRepoFromServer = artifactory.repository(virtualRepo).get();
             assertNotNull(virtualRepoFromServer);
             assertEquals(virtualRepoFromServer.getKey(), virtualRepo);
             assertEquals(virtualRepoFromServer.getDescription(), "new virtual huggingface repo");
             assertEquals(virtualRepoFromServer.getNotes(), "some notes");
-        } catch (org.apache.http.client.HttpResponseException e) {
-            System.err.println("[DIAG] Virtual repo creation failed with status: " + e.getStatusCode());
-            System.err.println("[DIAG] Error message: " + e.getMessage());
-            String msg = e.getMessage();
-            if (e.getStatusCode() == 400 && msg != null && msg.contains("unsupported in virtual repositories")) {
-                System.err.println("[DIAG] Skipping test - HuggingFaceML unsupported in virtual repos");
-                throw new SkipException("HuggingFaceML is unsupported in virtual repositories on this Artifactory version/plan.");
-            }
-            throw new RuntimeException(e);
-        }
-    }
-
-    private void printEnvironmentDiagnostics() {
-        try {
-            String versionJson = curl("api/system/version");
-            System.err.println("[DIAG] Artifactory version: " + versionJson);
-        } catch (Exception e) {
-            System.err.println("[DIAG] Failed to fetch version: " + e.getMessage());
-        }
-        try {
-            String licensesJson = curl("api/system/licenses");
-            System.err.println("[DIAG] Artifactory licenses: " + licensesJson);
-        } catch (Exception e1) {
-            try {
-                String licenseJson = curl("api/system/license");
-                System.err.println("[DIAG] Artifactory license: " + licenseJson);
-            } catch (Exception e2) {
-                System.err.println("[DIAG] Failed to fetch license info: " + e2.getMessage());
-            }
-        }
-    }
-
-    private void printRepositoryJson(String repoKey) {
-        try {
-            String repoJson = curl("api/repositories/" + repoKey);
-            System.err.println("[DIAG] Repository JSON (" + repoKey + "): " + repoJson);
-        } catch (Exception e) {
-            System.err.println("[DIAG] Failed to fetch repo JSON for '" + repoKey + "': " + e.getMessage());
-        }
     }
 }