Skip to content

Commit ad74e92

Browse files
committed
"adding the loggers as mentioned in the pr "
1 parent dd84324 commit ad74e92

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

services/src/test/java/org/jfrog/artifactory/client/ArtifactoryTestsBase.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.util.Arrays;
2727
import java.util.Collection;
2828
import java.util.Properties;
29+
import java.util.logging.Logger;
2930

3031
import static org.apache.commons.codec.binary.Base64.encodeBase64;
3132
import static org.apache.commons.lang3.StringUtils.isEmpty;
@@ -55,6 +56,7 @@ public abstract class ArtifactoryTestsBase {
5556
protected VirtualRepository virtualRepository;
5657
protected RemoteRepository remoteRepository;
5758
protected String federationUrl;
59+
private static final Logger logger = Logger.getLogger(ArtifactoryTestsBase.class.getName());
5860

5961
@BeforeClass
6062
public void init() throws IOException {
@@ -211,23 +213,31 @@ protected String textFrom(InputStream is) throws IOException {
211213
protected void deleteRepoWithRetry(String repoKey) {
212214
for (int attempt = 1; attempt <= 3; attempt++) {
213215
try {
216+
logger.info("Attempt " + attempt + " to delete repo: " + repoKey);
214217
deleteRepoIfExists(repoKey);
218+
logger.info("Successfully deleted repo: " + repoKey + " on attempt " + attempt);
215219
return;
216220
} catch (RuntimeException e) {
217221
Throwable cause = e.getCause();
222+
logger.warning("Attempt " + attempt + " failed to delete repo: " + repoKey + ". Reason: " + e.getMessage());
218223
if (cause instanceof HttpResponseException &&
219224
((HttpResponseException) cause).getStatusCode() == 500 &&
220225
cause.getMessage() != null && cause.getMessage().contains("Lock on LockEntryId")) {
221226

222227
if (attempt < 3) {
228+
logger.info("Lock detected. Retrying after 5 seconds...");
223229
try {
224230
Thread.sleep(5000);
225231
} catch (InterruptedException ie) {
226232
Thread.currentThread().interrupt();
233+
logger.warning("Retry interrupted while waiting to retry repo deletion: " + repoKey);
227234
return;
228235
}
236+
} else {
237+
logger.severe("Failed to delete repo after 3 attempts due to lock: " + repoKey);
229238
}
230239
} else {
240+
logger.severe("Non-lock error occurred. Not retrying. Repo: " + repoKey);
231241
return; // Non-lock error, don't retry
232242
}
233243
}

0 commit comments

Comments
 (0)