Skip to content

Commit afc1d41

Browse files
committed
refactor: remove validation step and update FlyFrog URL in integration test workflow; enhance CI end notification details in README
1 parent 9fdc038 commit afc1d41

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

.github/workflows/integration-test.yml

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,35 +10,13 @@ permissions:
1010
jobs:
1111
integration-test:
1212
runs-on: ubuntu-latest
13-
# Only run if a valid FlyFrog test URL is configured
14-
if: vars.FLYFROG_TEST_URL != ''
1513
steps:
1614
- name: Checkout repository
1715
uses: actions/checkout@v4
1816

19-
- name: Validate FlyFrog server endpoints
20-
run: |
21-
FLYFROG_URL="${{ vars.FLYFROG_TEST_URL || 'https://flyfrog.example.com' }}"
22-
echo "Testing FlyFrog server at: $FLYFROG_URL"
23-
24-
# Test if the server responds (basic connectivity check)
25-
if ! curl -s --max-time 10 "$FLYFROG_URL" > /dev/null; then
26-
echo "⚠️ Warning: FlyFrog server is not reachable"
27-
echo "Integration test may fail due to server connectivity"
28-
else
29-
echo "✅ FlyFrog server is reachable"
30-
fi
31-
3217
- name: Run FlyFrog action
3318
id: run-action
3419
uses: ./
3520
with:
36-
url: ${{ vars.FLYFROG_TEST_URL || 'https://flyfrog.example.com' }}
21+
url: ${{ vars.FLYFROG_TEST_URL || 'https://ffjob1682705.jfrogdev.org' }}
3722
ignore: docker, podman
38-
39-
- name: Assert action completed successfully
40-
run: |
41-
echo "✅ FlyFrog action completed without errors"
42-
echo " - OIDC authentication succeeded"
43-
echo " - Package managers configured successfully"
44-
echo " - CI end notification completed"

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ When using OIDC authentication:
6262
- Request an OIDC token from GitHub Actions
6363
- Exchange it for a FlyFrog access token via the `/flyfrog/api/v1/ci/start-oidc` endpoint
6464
- Use the resulting token to authenticate with FlyFrog
65-
- Notify CI session end via the `/flyfrog/api/v1/ci/end` endpoint on completion
65+
- Automatically notify CI session end via the `/flyfrog/api/v1/ci/end` endpoint when the job completes (using GitHub Actions post-job mechanism)
66+
67+
> **Note**: The CI end notification runs automatically after the main action completes, regardless of whether the main action succeeds or fails. This ensures proper cleanup and session management on the FlyFrog server.
6668

6769
### FlyFrog Server Configuration for OIDC
6870

0 commit comments

Comments
 (0)