Revert "Fix: Remove extra empty header row in no-header markdown tables" (#1023)

eyalk007 · web-flow · commit cc7b842295af · 2026-01-07T11:46:36.000+02:00
This reverts commit dfb15a8.
diff --git a/testdata/messages/integration/test_proj_pip_with_vulnerability.md b/testdata/messages/integration/test_proj_pip_with_vulnerability.md
@@ -39,6 +39,7 @@
 <details><summary><b>[ CVE-2022-29217 ] pyjwt 1.7.1</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Jfrog Research Severity:** | <img src="https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/smallMedium.svg" alt=""/> Medium |
 | **Contextual Analysis:** | Not Covered |
@@ -83,6 +84,7 @@ With -
 <details><summary><b>[ CVE-2025-45768 ] pyjwt 1.7.1</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Jfrog Research Severity:** | <img src="https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/smallLow.svg" alt=""/> Low |
 | **Contextual Analysis:** | Not Applicable |
diff --git a/testdata/messages/integration/test_proj_with_vulnerability_simplified.md b/testdata/messages/integration/test_proj_with_vulnerability_simplified.md
@@ -43,6 +43,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Jfrog Research Severity:** | 🔴 High |
 | **Contextual Analysis:** | Not Applicable |
diff --git a/testdata/messages/integration/test_proj_with_vulnerability_standard.md b/testdata/messages/integration/test_proj_with_vulnerability_standard.md
@@ -37,6 +37,7 @@
 
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Jfrog Research Severity:** | <img src="https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/smallHigh.svg" alt=""/> High |
 | **Contextual Analysis:** | Not Applicable |
diff --git a/testdata/messages/reviewcomment/sast/sast_review_content_no_code_flow_simplified.md b/testdata/messages/reviewcomment/sast/sast_review_content_no_code_flow_simplified.md
@@ -20,6 +20,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/sast/sast_review_content_no_code_flow_standard.md b/testdata/messages/reviewcomment/sast/sast_review_content_no_code_flow_standard.md
@@ -12,6 +12,7 @@
 <details><summary><b>Full description</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/sast/sast_review_content_simplified.md b/testdata/messages/reviewcomment/sast/sast_review_content_simplified.md
@@ -20,6 +20,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/sast/sast_review_content_standard.md b/testdata/messages/reviewcomment/sast/sast_review_content_standard.md
@@ -12,6 +12,7 @@
 <details><summary><b>Full description</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/sast/sast_violation_review_content_simplified.md b/testdata/messages/reviewcomment/sast/sast_violation_review_content_simplified.md
@@ -22,6 +22,7 @@
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Rule ID:** | js-express-without-helmet |
 
@@ -40,6 +41,7 @@ Scanner Description....
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/sast/sast_violation_review_content_standard.md b/testdata/messages/reviewcomment/sast/sast_violation_review_content_standard.md
@@ -14,6 +14,7 @@
 <details><summary><b>[ Express Not Using Helmet ]</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Rule ID:** | js-express-without-helmet |
 
@@ -23,6 +24,7 @@ Scanner Description....
 <details><summary><b>[ Use of Insecure Random ]</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Rule ID:** | js-insecure-random |
diff --git a/testdata/messages/reviewcomment/secrets/secret_review_content_no_ca_simplified.md b/testdata/messages/reviewcomment/secrets/secret_review_content_no_ca_simplified.md
@@ -20,6 +20,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/reviewcomment/secrets/secret_review_content_no_ca_standard.md b/testdata/messages/reviewcomment/secrets/secret_review_content_no_ca_standard.md
@@ -12,6 +12,7 @@
 <details><summary><b>Full description</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/reviewcomment/secrets/secret_review_content_simplified.md b/testdata/messages/reviewcomment/secrets/secret_review_content_simplified.md
@@ -20,6 +20,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/reviewcomment/secrets/secret_review_content_standard.md b/testdata/messages/reviewcomment/secrets/secret_review_content_standard.md
@@ -12,6 +12,7 @@
 <details><summary><b>Full description</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/reviewcomment/secrets/secret_violation_review_content_simplified.md b/testdata/messages/reviewcomment/secrets/secret_violation_review_content_simplified.md
@@ -21,6 +21,7 @@
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798, CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/reviewcomment/secrets/secret_violation_review_content_standard.md b/testdata/messages/reviewcomment/secrets/secret_violation_review_content_standard.md
@@ -13,6 +13,7 @@
 <details><summary><b>Full description</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CWE:** | CWE-798<br>CWE-799 |
 | **Abbreviation:** | rule-id |
diff --git a/testdata/messages/summarycomment/violations/license/license_violation_simplified.md b/testdata/messages/summarycomment/violations/license/license_violation_simplified.md
@@ -37,6 +37,7 @@
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Policies:** | policy1, policy2 |
 | **Watch Name:** | watch |
@@ -58,6 +59,7 @@
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Policies:** | policy3 |
 | **Watch Name:** | watch2 |
diff --git a/testdata/messages/summarycomment/violations/license/license_violation_standard.md b/testdata/messages/summarycomment/violations/license/license_violation_standard.md
@@ -20,6 +20,7 @@
 <details><summary><b>[ License1 ] Dep1 2.0 (watch)</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Policies:** | policy1, policy2 |
 | **Watch Name:** | watch |
@@ -32,6 +33,7 @@
 <details><summary><b>[ License2 ] Dep2 3.0 (watch2)</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Policies:** | policy3 |
 | **Watch Name:** | watch2 |
diff --git a/testdata/messages/summarycomment/violations/security/security_violation_simplified.md b/testdata/messages/summarycomment/violations/security/security_violation_simplified.md
@@ -33,6 +33,7 @@
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/nats-io/nats-streaming-server: v0.21.0 (Direct): Fix Version: [0.24.1] |
@@ -61,6 +62,7 @@ some remediation
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -88,6 +90,7 @@ some remediation
 ### Violation Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/mholt/archiver/v3: v3.5.1 (Direct): |
diff --git a/testdata/messages/summarycomment/violations/security/security_violation_standard.md b/testdata/messages/summarycomment/violations/security/security_violation_standard.md
@@ -20,6 +20,7 @@
 <details><summary><b>[ XRAY-122345 ] github.com/nats-io/nats-streaming-server v0.21.0</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/nats-io/nats-streaming-server: v0.21.0 (Direct)</b></summary>Fix Version: [0.24.1]<br></details> |
@@ -35,6 +36,7 @@ some remediation
 <details><summary><b>[ CVE-2022-26652, CVE-2023-4321 ] component-D v0.21.0</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -49,6 +51,7 @@ some remediation
 <details><summary><b>github.com/mholt/archiver/v3 v3.5.1</b></summary>
 
 ### Violation Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/mholt/archiver/v3: v3.5.1 (Direct)</b></summary><br></details> |
diff --git a/testdata/messages/summarycomment/vulnerabilities/one_vulnerability_simplified.md b/testdata/messages/summarycomment/vulnerabilities/one_vulnerability_simplified.md
@@ -23,6 +23,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/nats-io/nats-streaming-server: v0.21.0 (Direct): Fix Version: [0.24.3] |
diff --git a/testdata/messages/summarycomment/vulnerabilities/one_vulnerability_standard.md b/testdata/messages/summarycomment/vulnerabilities/one_vulnerability_standard.md
@@ -11,6 +11,7 @@
 
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/nats-io/nats-streaming-server: v0.21.0 (Direct)</b></summary>Fix Version: [0.24.3]<br></details> |
diff --git a/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_simplified.md b/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_simplified.md
@@ -32,6 +32,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/nats-io/nats-streaming-server: v0.21.0 (Direct): Fix Version: [0.24.1] |
@@ -60,6 +61,7 @@ some remediation
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -87,6 +89,7 @@ some remediation
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/mholt/archiver/v3: v3.5.1 (Direct): |
diff --git a/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_simplified_split2.md b/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_simplified_split2.md
@@ -26,6 +26,7 @@
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/nats-io/nats-streaming-server: v0.21.0 (Direct): Fix Version: [0.24.1] |
@@ -54,6 +55,7 @@ some remediation
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -88,6 +90,7 @@ some remediation
 ### Vulnerability Details
 
 ---
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | github.com/mholt/archiver/v3: v3.5.1 (Direct): |
diff --git a/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_standard.md b/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_standard.md
@@ -15,6 +15,7 @@
 <details><summary><b>[ XRAY-122345 ] github.com/nats-io/nats-streaming-server v0.21.0</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/nats-io/nats-streaming-server: v0.21.0 (Direct)</b></summary>Fix Version: [0.24.1]<br></details> |
@@ -30,6 +31,7 @@ some remediation
 <details><summary><b>[ CVE-2022-26652, CVE-2023-4321 ] component-D v0.21.0</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -44,6 +46,7 @@ some remediation
 <details><summary><b>github.com/mholt/archiver/v3 v3.5.1</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/mholt/archiver/v3: v3.5.1 (Direct)</b></summary><br></details> |
diff --git a/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_standard_split2.md b/testdata/messages/summarycomment/vulnerabilities/vulnerabilities_standard_split2.md
@@ -9,6 +9,7 @@
 <details><summary><b>[ XRAY-122345 ] github.com/nats-io/nats-streaming-server v0.21.0</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/nats-io/nats-streaming-server: v0.21.0 (Direct)</b></summary>Fix Version: [0.24.1]<br></details> |
@@ -24,6 +25,7 @@ some remediation
 <details><summary><b>[ CVE-2022-26652, CVE-2023-4321 ] component-D v0.21.0</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **Contextual Analysis:** | Applicable |
 | **CVSS V3:** | - |
@@ -38,6 +40,7 @@ some remediation
 <details><summary><b>github.com/mholt/archiver/v3 v3.5.1</b></summary>
 
 ### Vulnerability Details
+|                 |                   |
 | --------------------- | :-----------------------------------: |
 | **CVSS V3:** | - |
 | **Dependency Path:** | <details><summary><b>github.com/mholt/archiver/v3: v3.5.1 (Direct)</b></summary><br></details> |
diff --git a/utils/outputwriter/markdowntable.go b/utils/outputwriter/markdowntable.go
@@ -154,31 +154,22 @@ func (t *MarkdownTableBuilder) Build() string {
 			t.columns[c].shouldHideColumn = t.columns[c].shouldHideColumn && (len(cell) == 0 || (len(cell) == 1 && cell[0] == ""))
 		}
 	}
-	// Header - only write if at least one column has a non-empty name
-	hasHeaderNames := false
+	// Header
+	isFirstCol := true
 	for _, column := range t.columns {
-		if !column.shouldHideColumn && column.Name != "" {
-			hasHeaderNames = true
-			break
+		if column.shouldHideColumn {
+			continue
 		}
-	}
-	if hasHeaderNames {
-		isFirstCol := true
-		for _, column := range t.columns {
-			if column.shouldHideColumn {
-				continue
-			}
-			if isFirstCol {
-				tableBuilder.WriteString(fmt.Sprintf(firstCellPlaceholder, column.Name))
-			} else {
-				tableBuilder.WriteString(fmt.Sprintf(cellPlaceholder, column.Name))
-			}
-			isFirstCol = false
+		if isFirstCol {
+			tableBuilder.WriteString(fmt.Sprintf(firstCellPlaceholder, column.Name))
+		} else {
+			tableBuilder.WriteString(fmt.Sprintf(cellPlaceholder, column.Name))
 		}
-		tableBuilder.WriteString("\n")
+		isFirstCol = false
 	}
+	tableBuilder.WriteString("\n")
 	// Separator
-	isFirstCol := true
+	isFirstCol = true
 	for _, column := range t.columns {
 		if column.shouldHideColumn {
 			continue
