Add support for fail_pr rule (watches) in scan pull requests#876
Merged
eranturgeman merged 12 commits intojfrog:devfrom Jun 25, 2025
Merged
Add support for fail_pr rule (watches) in scan pull requests#876eranturgeman merged 12 commits intojfrog:devfrom
eranturgeman merged 12 commits intojfrog:devfrom
Conversation
eranturgeman
added
safe to test
github-actions
bot
removed
the
safe to test
orz25
reviewed
Jun 18, 2025
orz25
reviewed
Jun 18, 2025
orz25
reviewed
Jun 18, 2025
Contributor
|
Can we add an e2e test with the following:
|
…iolations-fail-pr-support # Conflicts: # go.mod # go.sum
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to the new fail_pull_request action that was introduced to P&W.
The new action is similar to fail_build, but is intended to PRs only and works as follows:
When a violation with fail_pull_request action applied to one of its rules is found - we fail PR build.