Refactor NPM package updater #1024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… location extraction for a given VulnerabilityDetails
eranturgeman
added
safe to test
github-actions
bot
removed
the
safe to test
…r-npm-package-updater
Collaborator
|
please provide a link to a fix pr |
eyalk007
requested changes
Jan 8, 2026
Collaborator
eyalk007
left a comment
eyalk007
left a comment
There was a problem hiding this comment.
reviewed most of files
please tell me you are done so i can rereveiw
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
orto17
reviewed
Jan 12, 2026
…r-npm-package-updater
Contributor
Author
https://github.com/eranturgeman/npm-small/pull/14 
|
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the NPM package handler to test-based fixes instead of cli command fixes.
As past of the change we ease the installation after a fix is performed to only regenerate the lock file, hence reducing the strict build process we used to have and make the process less error prone
Missing testcase:
We need to add a new integration test test case to TestScanRepositoryCmd_Run that verifies we do not regenerate a lock file if it doesnt exists in remote. since the TestScanRepositoryCmd_Run is not passing right now and we need to fix it I added it to the overall test plan for future addition