fix unit tests

Author: EyalDelarea

apptrust/commands/utils/utils.go

@@ -125,6 +125,9 @@ func ParseDelimitedSlice(input string) [][]string {
 // Returns an error if any entry does not have exactly two parts.
 func ParseNameVersionPairs(input string) ([][2]string, error) {
 	var result [][2]string
+	if input == "" {
+		return result, nil
+	}
 	for _, parts := range ParseDelimitedSlice(input) {
 		if len(parts) != 2 {
 			return nil, fmt.Errorf("invalid format: %v", parts)

apptrust/commands/utils/utils_test.go

@@ -155,7 +155,7 @@ func TestParseDelimitedSlice(t *testing.T) {
 		input    string
 		expected [][]string
 	}{
-		{"empty string", "", [][]string{}},
+		{"empty string", "", nil},
 		{"single entry", "foo:bar", [][]string{{"foo", "bar"}}},
 		{"multiple entries", "foo:bar;baz:qux", [][]string{{"foo", "bar"}, {"baz", "qux"}}},
 		{"entries with extra parts", "a:1:2;b:3", [][]string{{"a", "1", "2"}, {"b", "3"}}},
@@ -170,3 +170,30 @@ func TestParseDelimitedSlice(t *testing.T) {
 		})
 	}
 }
+
+func TestParseNameVersionPairs(t *testing.T) {
+	tests := []struct {
+		name      string
+		input     string
+		expected  [][2]string
+		expectErr bool
+	}{
+		{"empty string", "", nil, false},
+		{"single pair", "foo:1.0.0", [][2]string{{"foo", "1.0.0"}}, false},
+		{"multiple pairs", "foo:1.0.0;bar:2.0.0", [][2]string{{"foo", "1.0.0"}, {"bar", "2.0.0"}}, false},
+		{"spaces", " foo:1.0.0 ; bar:2.0.0 ", [][2]string{{" foo", "1.0.0 "}, {" bar", "2.0.0 "}}, false},
+		{"invalid format", "foo", nil, true},
+		{"too many parts", "foo:1.0.0:extra", nil, true},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := ParseNameVersionPairs(tt.input)
+			if tt.expectErr {
+				assert.Error(t, err, "expected error for input %q", tt.input)
+				return
+			}
+			assert.NoError(t, err, "unexpected error for input %q: %v", tt.input, err)
+			assert.Equal(t, tt.expected, result, "ParseNameVersionPairs(%q) = %v, want %v", tt.input, result, tt.expected)
+		})
+	}
+}

apptrust/commands/version/create_app_version_cmd_test.go

@@ -7,6 +7,7 @@ import (
 	mockversions "github.com/jfrog/jfrog-cli-application/apptrust/service/versions/mocks"
 	"go.uber.org/mock/gomock"
 
+	"github.com/jfrog/jfrog-cli-application/apptrust/commands"
 	"github.com/jfrog/jfrog-cli-application/apptrust/model"
 	"github.com/jfrog/jfrog-cli-core/v2/plugins/components"
 	"github.com/jfrog/jfrog-cli-core/v2/utils/config"
@@ -114,11 +115,11 @@ func TestCreateAppVersionCommand_FlagsSuite(t *testing.T) {
 			name: "all flags",
 			ctxSetup: func(ctx *components.Context) {
 				ctx.Arguments = []string{"app-key", "1.0.0"}
-				ctx.AddStringFlag("tag", "release-tag")
-				ctx.AddStringFlag("packages", "pkg1:1.2.3,pkg2:2.3.4")
-				ctx.AddStringFlag("build", "build1:1.0.0:2024-01-01;build2:2.0.0:2024-02-01")
-				ctx.AddStringFlag("release-bundle", "rb1:1.0.0;rb2:2.0.0")
-				ctx.AddStringFlag("source-version", "source-app:3.2.1")
+				ctx.AddStringFlag(commands.TagFlag, "release-tag")
+				ctx.AddStringFlag(commands.PackagesFlag, "pkg1:1.2.3,pkg2:2.3.4")
+				ctx.AddStringFlag(commands.BuildsFlag, "build1:1.0.0:2024-01-01;build2:2.0.0:2024-02-01")
+				ctx.AddStringFlag(commands.ReleaseBundlesFlag, "rb1:1.0.0;rb2:2.0.0")
+				ctx.AddStringFlag(commands.SourceVersionFlag, "source-app:3.2.1")
 			},
 			expectsPayload: &model.CreateAppVersionRequest{
 				ApplicationKey: "app-key",
@@ -129,8 +130,14 @@ func TestCreateAppVersionCommand_FlagsSuite(t *testing.T) {
 						{Name: "pkg1", Version: "1.2.3"},
 						{Name: "pkg2", Version: "2.3.4"},
 					},
-					Builds:         nil,
-					ReleaseBundles: nil,
+					Builds: []model.CreateVersionBuild{
+						{Name: "build1", Number: "1.0.0", Started: "2024-01-01"},
+						{Name: "build2", Number: "2.0.0", Started: "2024-02-01"},
+					},
+					ReleaseBundles: []model.CreateVersionReleaseBundle{
+						{Name: "rb1", Version: "1.0.0"},
+						{Name: "rb2", Version: "2.0.0"},
+					},
 					Versions: []model.CreateVersionReference{
 						{ApplicationKey: "source-app", Version: "3.2.1"},
 					},