Application Key flag is optional now

Author: alenon

.github/workflows/tests.yml

@@ -33,15 +33,13 @@ jobs:
           restore-keys: go-
 
       - name: Run Tests
-        env:
-          XUNIT_OUTFILE: test-reports/unit.xml
         run: |
-          make test
+          make test-ci
 
       - name: Publish Results
         uses: EnricoMi/publish-unit-test-result-action@v2
         if: always()
         with:
           check_name: Unit Tests Results
           files: |
-            test-reports/unit.xml
+            utests-report.xml

Makefile

@@ -45,8 +45,9 @@ GOLANGCI_LINT:
 
 ########## BUILD ##########
 prereq::
-	$(GOCMD) install github.com/jstemmer/go-junit-report@v1.0.0
+	$(GOCMD) install github.com/jstemmer/go-junit-report/v2@latest
 	GOBIN=${TOOLS_DIR} $(GOCMD) install go.uber.org/mock/[email protected]
+	mockgen --version
 
 build::
 	$(GOCMD) env GOOS GOARCH
@@ -79,15 +80,8 @@ test-prereq: generate-mock
 	mkdir -p target/reports
 
 test: PACKAGES=./...
-test: TEST_ARGS=-short
-test: test-prereq do-run-tests
+test: test-prereq
+	go test ./...
+test-ci: test-prereq
+	go test -v 2>&1 ./... | go-junit-report -set-exit-code -iocopy -out utests-report.xml
 
-itest: PACKAGES=./test/...
-itest: TAGS=-tags=itest
-itest: TEST_ARGS=-count=1 -p=1
-itest:: test-prereq do-run-tests
-
-do-run-tests::
-	$(SCRIPTS_DIR)/gotest.sh $$(go list $(TAGS) $(PACKAGES) | grep -v "^.*/mocks$$") -timeout 30m -coverpkg=github.com/jfrog/jfrog-cli-application/... -coverprofile=$(TARGET_DIR)/reports/coverage.out $(TEST_ARGS) $(TAGS)
-
-.PHONY: $(MAKECMDGOALS)

scripts/gotest.sh

@@ -69,7 +69,7 @@ fi
 
 echoDebug "Running ${GOCMD} test ${modargs[*]}"
 # Disable log coloring (ANSI codes are invalid xml characters)
-(2>&1 DEV_DISABLE_LOG_COLORS=true ${GOCMD} test ${modargs[*]} || echo "$?" > "${exitCodeFile}") | tee "${OUTFILE}"
+(2>&1 DEV_DISABLE_LOG_COLORS=true ${GOCMD} test "${modargs[*]}" || echo "$?" > "${exitCodeFile}") | tee "${OUTFILE}"
 exitCode="$(cat "${exitCodeFile}")"
 echoDebug "Tests Exit Code: $exitCode"
 
@@ -79,8 +79,6 @@ if [[ -n "${JSON_OUTFILE}" ]]; then
 fi
 
 if [[ -n "${XUNIT_OUTFILE}" ]]; then
-  echoDebug "Ensuring jstemmer/go-junit-report is installed"
-  ${GOCMD} install github.com/jstemmer/[email protected]
   echoDebug "Generating xUnit test report at: ${XUNIT_OUTFILE}"
   go-junit-report < "${OUTFILE}" > "${XUNIT_OUTFILE}"
 fi