Added create version command

Author: alenon

application/http/http_client.go

@@ -1,13 +1,31 @@
 package http
 
 import (
+	"encoding/json"
 	commonCliConfig "github.com/jfrog/jfrog-cli-core/v2/utils/config"
 	"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
+	"github.com/jfrog/jfrog-client-go/auth"
 	clientConfig "github.com/jfrog/jfrog-client-go/config"
 	"github.com/jfrog/jfrog-client-go/http/jfroghttpclient"
+	"github.com/jfrog/jfrog-client-go/utils"
+	"github.com/jfrog/jfrog-client-go/utils/errorutils"
+	"github.com/jfrog/jfrog-client-go/utils/io/httputils"
+	"net/http"
 )
 
-func NewAppHttpClient(serverDetails *commonCliConfig.ServerDetails) (*jfroghttpclient.JfrogHttpClient, error) {
+type AppHttpClient interface {
+	GetHttpClient() *jfroghttpclient.JfrogHttpClient
+	Post(path string, requestBody interface{}) (resp *http.Response, body []byte, err error)
+}
+
+type appHttpClient struct {
+	client        *jfroghttpclient.JfrogHttpClient
+	serverDetails *commonCliConfig.ServerDetails
+	authDetails   auth.ServiceDetails
+	serviceConfig clientConfig.Config
+}
+
+func NewAppHttpClient(serverDetails *commonCliConfig.ServerDetails) (AppHttpClient, error) {
 	certsPath, err := coreutils.GetJfrogCertsDir()
 	if err != nil {
 		return nil, err
@@ -27,7 +45,7 @@ func NewAppHttpClient(serverDetails *commonCliConfig.ServerDetails) (*jfroghttpc
 		return nil, err
 	}
 
-	return jfroghttpclient.JfrogClientBuilder().
+	jfHttpClient, err := jfroghttpclient.JfrogClientBuilder().
 		SetCertificatesPath(certsPath).
 		SetInsecureTls(serviceConfig.IsInsecureTls()).
 		SetClientCertPath(serverDetails.GetClientCertPath()).
@@ -39,4 +57,40 @@ func NewAppHttpClient(serverDetails *commonCliConfig.ServerDetails) (*jfroghttpc
 		SetRetries(serviceConfig.GetHttpRetries()).
 		SetRetryWaitMilliSecs(serviceConfig.GetHttpRetryWaitMilliSecs()).
 		Build()
+
+	if err != nil {
+		return nil, err
+	}
+
+	appClient := &appHttpClient{
+		client:        jfHttpClient,
+		serverDetails: serverDetails,
+		authDetails:   authDetails,
+		serviceConfig: serviceConfig,
+	}
+	return appClient, nil
+}
+
+func (c *appHttpClient) GetHttpClient() *jfroghttpclient.JfrogHttpClient {
+	return c.client
+}
+
+func (c *appHttpClient) Post(path string, requestBody interface{}) (resp *http.Response, body []byte, err error) {
+	url, err := utils.BuildUrl(c.serverDetails.Url, path, nil)
+	if err != nil {
+		return nil, nil, err
+	}
+
+	var requestContent []byte
+	if requestBody != nil {
+		requestContent, err = json.Marshal(requestBody)
+		if err != nil {
+			return nil, nil, errorutils.CheckError(err)
+		}
+	}
+
+	var httpClientDetails httputils.HttpClientDetails
+	httpClientDetails = c.authDetails.CreateHttpClientDetails()
+	httpClientDetails.SetContentTypeApplicationJson()
+	return c.client.SendPost(url, requestContent, &httpClientDetails)
 }

application/service/version_service.go

@@ -1,12 +1,9 @@
 package service
 
 import (
-	"encoding/json"
+	"fmt"
 	"github.com/jfrog/jfrog-cli-application/application/http"
 	"github.com/jfrog/jfrog-cli-application/application/model"
-	"github.com/jfrog/jfrog-client-go/utils"
-	"github.com/jfrog/jfrog-client-go/utils/errorutils"
-	"github.com/jfrog/jfrog-client-go/utils/io/httputils"
 )
 
 type VersionService interface {
@@ -26,24 +23,13 @@ func (vs *versionService) CreateAppVersion(ctx *Context, request *model.CreateAp
 		return err
 	}
 
-	authDetails, err := ctx.ServerDetails.CreateLifecycleAuthConfig()
+	response, _, err := httpClient.Post("application/version", request)
 	if err != nil {
 		return err
 	}
 
-	requestContent, err := json.Marshal(request)
-	if err != nil {
-		return errorutils.CheckError(err)
-	}
-
-	var httpClientDetails httputils.HttpClientDetails
-	httpClientDetails = authDetails.CreateHttpClientDetails()
-	httpClientDetails.SetContentTypeApplicationJson()
-
-	requestFullUrl, err := utils.BuildUrl(ctx.ServerDetails.Url, "application/version", nil)
-	_, _, err = httpClient.SendPost(requestFullUrl, requestContent, &httpClientDetails)
-	if err != nil {
-		return err
+	if response.StatusCode != 201 {
+		return fmt.Errorf("failed to create app version. Status code: %d", response.StatusCode)
 	}
 
 	return nil