fix unit tests

Author: EyalDelarea

apptrust/commands/utils/utils.go

@@ -95,7 +95,7 @@ func ParsePackagesFlag(flagValue string) ([]map[string]string, error) {
 		return nil, nil
 	}
 	pairs := strings.Split(flagValue, ",")
-	var result []map[string]string
+	result := []map[string]string{}
 	for _, pair := range pairs {
 		parts := strings.SplitN(strings.TrimSpace(pair), PartSeparator, 2)
 		if len(parts) != 2 {
@@ -109,7 +109,7 @@ func ParsePackagesFlag(flagValue string) ([]map[string]string, error) {
 // ParseDelimitedSlice splits a delimited string into a slice of string slices.
 // Example: input "a:1;b:2" returns [][]string{{"a","1"},{"b","2"}}
 func ParseDelimitedSlice(input string) [][]string {
-	var result [][]string
+	result := [][]string{}
 	if input == "" {
 		return result
 	}
@@ -124,7 +124,10 @@ func ParseDelimitedSlice(input string) [][]string {
 // ParseNameVersionPairs parses a delimited string (e.g., "name1:version1;name2:version2") into a slice of [2]string pairs.
 // Returns an error if any entry does not have exactly two parts.
 func ParseNameVersionPairs(input string) ([][2]string, error) {
-	var result [][2]string
+	result := [][2]string{}
+	if input == "" {
+		return result, nil
+	}
 	for _, parts := range ParseDelimitedSlice(input) {
 		if len(parts) != 2 {
 			return nil, fmt.Errorf("invalid format: %v", parts)

apptrust/commands/utils/utils_test.go

@@ -170,3 +170,30 @@ func TestParseDelimitedSlice(t *testing.T) {
 		})
 	}
 }
+
+func TestParseNameVersionPairs(t *testing.T) {
+	tests := []struct {
+		name      string
+		input     string
+		expected  [][2]string
+		expectErr bool
+	}{
+		{"empty string", "", [][2]string{}, false},
+		{"single pair", "foo:1.0.0", [][2]string{{"foo", "1.0.0"}}, false},
+		{"multiple pairs", "foo:1.0.0;bar:2.0.0", [][2]string{{"foo", "1.0.0"}, {"bar", "2.0.0"}}, false},
+		{"spaces", " foo:1.0.0 ; bar:2.0.0 ", [][2]string{{" foo", "1.0.0 "}, {" bar", "2.0.0 "}}, false},
+		{"invalid format", "foo", nil, true},
+		{"too many parts", "foo:1.0.0:extra", nil, true},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := ParseNameVersionPairs(tt.input)
+			if tt.expectErr {
+				assert.Error(t, err, "expected error for input %q", tt.input)
+				return
+			}
+			assert.NoError(t, err, "unexpected error for input %q: %v", tt.input, err)
+			assert.Equal(t, tt.expected, result, "ParseNameVersionPairs(%q) = %v, want %v", tt.input, result, tt.expected)
+		})
+	}
+}