Skip to content

Commit 99f5794

Browse files
committed
fix lint issue
1 parent 19b83fb commit 99f5794

File tree

4 files changed

+33
-10
lines changed

4 files changed

+33
-10
lines changed

evidence/create/create_build_test.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,10 @@ func TestBuildInfo(t *testing.T) {
7878

7979
for _, tt := range tests {
8080
t.Run(tt.name, func(t *testing.T) {
81-
c := NewCreateEvidenceBuild(nil, "", "", "", "", "", tt.project, tt.buildName, tt.buildNumber).(*createEvidenceBuild)
81+
c, ok := NewCreateEvidenceBuild(nil, "", "", "", "", "", tt.project, tt.buildName, tt.buildNumber).(*createEvidenceBuild)
82+
if !ok {
83+
t.Fatal("Failed to create createEvidenceBuild instance")
84+
}
8285
aa := &mockArtifactoryServicesManagerBuild{}
8386
timestamp, err := getBuildLatestTimestamp(tt.buildName, tt.buildNumber, tt.project, aa)
8487
assert.NoError(t, err)
@@ -120,7 +123,7 @@ func TestCreateEvidenceBuild_RecordSummary(t *testing.T) {
120123
Password: "testpass",
121124
}
122125

123-
c := NewCreateEvidenceBuild(
126+
evidence := NewCreateEvidenceBuild(
124127
serverDetails,
125128
predicateFile,
126129
"test-predicate-type",
@@ -130,7 +133,11 @@ func TestCreateEvidenceBuild_RecordSummary(t *testing.T) {
130133
"myProject",
131134
"testBuild",
132135
"123",
133-
).(*createEvidenceBuild)
136+
)
137+
c, ok := evidence.(*createEvidenceBuild)
138+
if !ok {
139+
t.Fatal("Failed to create createEvidenceBuild instance")
140+
}
134141

135142
expectedResponse := &model.CreateResponse{
136143
PredicateSlug: "test-slug",

evidence/create/create_custom_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ func TestCreateEvidenceCustom_RecordSummary(t *testing.T) {
310310
subjectRepoPath := "test-repo/path/to/artifact.jar"
311311
subjectSha256 := "custom-sha256"
312312

313-
c := NewCreateEvidenceCustom(
313+
evidence := NewCreateEvidenceCustom(
314314
serverDetails,
315315
"",
316316
"custom-predicate-type",
@@ -321,7 +321,11 @@ func TestCreateEvidenceCustom_RecordSummary(t *testing.T) {
321321
subjectSha256,
322322
"",
323323
"test-provider",
324-
).(*createEvidenceCustom)
324+
)
325+
c, ok := evidence.(*createEvidenceCustom)
326+
if !ok {
327+
t.Fatal("Failed to create createEvidenceCustom instance")
328+
}
325329

326330
expectedResponse := &model.CreateResponse{
327331
PredicateSlug: "custom-slug",

evidence/create/create_package_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func TestCreateEvidencePackage_RecordSummary(t *testing.T) {
8484
packageVersion := "1.0.0"
8585
repoName := "maven-local"
8686

87-
c := NewCreateEvidencePackage(
87+
evidence := NewCreateEvidencePackage(
8888
serverDetails,
8989
"",
9090
"test-predicate-type",
@@ -94,7 +94,11 @@ func TestCreateEvidencePackage_RecordSummary(t *testing.T) {
9494
packageName,
9595
packageVersion,
9696
repoName,
97-
).(*createEvidencePackage)
97+
)
98+
c, ok := evidence.(*createEvidencePackage)
99+
if !ok {
100+
t.Fatal("Failed to create createEvidencePackage instance")
101+
}
98102

99103
expectedResponse := &model.CreateResponse{
100104
PredicateSlug: "test-slug",

evidence/create/create_release_bundle_test.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,11 @@ func TestReleaseBundle(t *testing.T) {
7878

7979
for _, tt := range tests {
8080
t.Run(tt.name, func(t *testing.T) {
81-
c := NewCreateEvidenceReleaseBundle(nil, "", "", "", "", "", tt.project, tt.releaseBundle, tt.releaseBundleVersion).(*createEvidenceReleaseBundle)
81+
evidence := NewCreateEvidenceReleaseBundle(nil, "", "", "", "", "", tt.project, tt.releaseBundle, tt.releaseBundleVersion)
82+
c, ok := evidence.(*createEvidenceReleaseBundle)
83+
if !ok {
84+
t.Fatal("Failed to create createEvidenceReleaseBundle instance")
85+
}
8286
aa := &mockReleaseBundleArtifactoryServicesManager{}
8387
path, sha256, err := c.buildReleaseBundleSubjectPath(aa)
8488
if tt.expectError {
@@ -115,7 +119,7 @@ func TestCreateEvidenceReleaseBundle_RecordSummary(t *testing.T) {
115119
Password: "testpass",
116120
}
117121

118-
c := NewCreateEvidenceReleaseBundle(
122+
evidence := NewCreateEvidenceReleaseBundle(
119123
serverDetails,
120124
"",
121125
"test-predicate-type",
@@ -125,7 +129,11 @@ func TestCreateEvidenceReleaseBundle_RecordSummary(t *testing.T) {
125129
"myProject",
126130
"testBundle",
127131
"2.0.0",
128-
).(*createEvidenceReleaseBundle)
132+
)
133+
c, ok := evidence.(*createEvidenceReleaseBundle)
134+
if !ok {
135+
t.Fatal("Failed to create createEvidenceReleaseBundle instance")
136+
}
129137

130138
expectedResponse := &model.CreateResponse{
131139
PredicateSlug: "test-rb-slug",

0 commit comments

Comments
 (0)