Fix actions of fork PRs

Author: ehl-jf

.github/dependabot.yml

@@ -7,6 +7,16 @@
     open-pull-requests-limit: 10
     groups:
       go:
+        update-types:
+          - minor
+          - patch
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 5
+    groups:
+      github-actions:
         update-types:
           - minor
           - patch

.github/workflows/analysis.yml

@@ -15,6 +15,8 @@ jobs:
     steps:
       - name: Checkout Source
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Setup Go with cache
         uses: jfrog/.github/actions/install-go-with-cache@main
@@ -27,6 +29,9 @@ jobs:
     steps:
       - name: Checkout Source
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha || github.ref }}
+          fetch-depth: 0
 
       - name: Setup Go with cache
         uses: jfrog/.github/actions/install-go-with-cache@main
@@ -39,6 +44,9 @@ jobs:
     steps:
       - name: Checkout Source
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha || github.ref }}
+          fetch-depth: 0
 
       - name: Check for uncommented replace instructions
         run: |

.github/workflows/dependabot-auto-merge.yml

@@ -0,0 +1,25 @@
+name: Dependabot auto-merge
+on:
+  pull_request_target:
+    branches:
+      - master
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  dependabot:
+    runs-on: ubuntu-latest
+    if: github.event.pull_request.user.login == 'dependabot[bot]' && github.repository == 'jfrog/jfrog-cli-core'
+    steps:
+      - name: Dependabot metadata
+        id: metadata
+        uses: dependabot/[email protected]
+        with:
+          github-token: "${{ secrets.GITHUB_TOKEN }}"
+      - name: Enable auto-merge for Dependabot PRs
+        run: gh pr merge --auto --squash "$PR_URL"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GH_TOKEN: ${{secrets.GITHUB_TOKEN}}

.github/workflows/frogbot-scan-repository.yml

@@ -121,7 +121,7 @@ jobs:
           # [Optional]
           # Set the minimum severity for vulnerabilities that should be fixed and commented on in pull requests
           # The following values are accepted: Low, Medium, High or Critical
-          # JF_MIN_SEVERITY: ""
+          JF_MIN_SEVERITY: "High"
 
           # [Optional, Default: [email protected]]
           # Set the email of the commit author

.github/workflows/monitor-stale.yml

@@ -14,7 +14,7 @@ jobs:
     permissions:
       issues: write
     steps:
-      - uses: actions/stale@v9
+      - uses: actions/stale@v10
         with:
           # Ignore issues with these labels
           exempt-issue-labels: "feature request,question"

.github/workflows/test.yml

@@ -21,7 +21,10 @@ jobs:
       GRADLE_OPTS: -Dorg.gradle.daemon=false
       JFROG_CLI_LOG_LEVEL: "DEBUG"
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha || github.ref }}
 
       - name: Setup Python3
         uses: actions/setup-python@v5

artifactory/utils/maven/settingsxml.go

@@ -133,6 +133,8 @@ func createNewDeploymentProfile(altDeploymentRepo string) maven.Profile {
 // configureArtifactoryDeployment configures Maven to deploy/push artifacts to Artifactory by default
 // This adds a profile with altDeploymentRepository properties that override any pom.xml distributionManagement
 // Uses the same server credentials as the mirror configuration (artifactory-mirror)
+//
+//nolint:unparam
 func (sxm *SettingsXmlManager) configureArtifactoryDeployment(repoUrl string) error {
 	// Build the altDeploymentRepository string for Maven Deploy Plugin
 	// Source: apache/maven-deploy-plugin/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java
@@ -219,6 +221,8 @@ func (sxm *SettingsXmlManager) updateMirror(repoUrl, repoName string) error {
 }
 
 // updateServerCredentials updates or adds server credentials in the settings.
+//
+//nolint:unparam
 func (sxm *SettingsXmlManager) updateServerCredentials(username, password string) error {
 	// Create the new server with the provided credentials
 	updatedServer := mavenv1.Server{
@@ -256,12 +260,12 @@ func (sxm *SettingsXmlManager) writeSettingsToFile() error {
 
 	// Add XML header and write to file
 	data = append([]byte(xml.Header), data...)
-	err = os.MkdirAll(filepath.Dir(sxm.path), 0755)
+	err = os.MkdirAll(filepath.Dir(sxm.path), 0o755)
 	if err != nil {
 		return fmt.Errorf("failed to create directory for settings file: %w", err)
 	}
 
-	err = os.WriteFile(sxm.path, data, 0644)
+	err = os.WriteFile(sxm.path, data, 0o644)
 	if err != nil {
 		return fmt.Errorf("failed to write settings to file %s: %w", sxm.path, err)
 	}

artifactory/utils/maven/settingsxml_test.go

@@ -11,6 +11,7 @@ import (
 	v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1"
 	"github.com/apache/camel-k/v2/pkg/util/maven"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 // cleanupTempDir safely removes a temporary directory and checks for errors
@@ -27,8 +28,15 @@ func TestNewSettingsXmlManager(t *testing.T) {
 
 	// Set up a test home directory
 	originalHome := os.Getenv("HOME")
-	defer os.Setenv("HOME", originalHome)
-	os.Setenv("HOME", tempDir)
+	defer func() {
+		err := os.Setenv("HOME", originalHome)
+		if err != nil {
+			t.Logf("Failed to set HOME environment variable: %v", err)
+		}
+	}()
+
+	err = os.Setenv("HOME", tempDir)
+	require.NoError(t, err)
 
 	// Test with non-existing settings file
 	manager, err := NewSettingsXmlManager()
@@ -79,7 +87,7 @@ func TestLoadSettings_ExistingFile(t *testing.T) {
   </mirrors>
 </settings>`
 
-	err = os.WriteFile(settingsPath, []byte(settingsContent), 0644)
+	err = os.WriteFile(settingsPath, []byte(settingsContent), 0o644)
 	assert.NoError(t, err, "Failed to write test settings file")
 
 	manager := &SettingsXmlManager{path: settingsPath}
@@ -310,8 +318,14 @@ func TestConfigureArtifactoryMirror_NoCredentials(t *testing.T) {
 
 	// Set up a test home directory
 	originalHome := os.Getenv("HOME")
-	defer os.Setenv("HOME", originalHome)
-	os.Setenv("HOME", tempDir)
+	defer func() {
+		err := os.Setenv("HOME", originalHome)
+		if err != nil {
+			t.Logf("Failed to set HOME environment variable: %v", err)
+		}
+	}()
+	err = os.Setenv("HOME", tempDir)
+	require.NoError(t, err)
 
 	manager, err := NewSettingsXmlManager()
 	assert.NoError(t, err, "Failed to create manager")
@@ -420,7 +434,7 @@ func TestDataPreservation_RoundTrip(t *testing.T) {
   </mirrors>
 </settings>`
 
-	err = os.WriteFile(settingsPath, []byte(originalContent), 0644)
+	err = os.WriteFile(settingsPath, []byte(originalContent), 0o644)
 	assert.NoError(t, err, "Failed to write original settings file")
 
 	// Load the settings