CR comments

eyalb4doc · eyalb4doc · commit 69479594ab7d · 2024-12-25T16:09:50.000+02:00
diff --git a/artifactory/utils/commandsummary/utils.go b/artifactory/utils/commandsummary/utils.go
@@ -45,8 +45,8 @@ type summarySection string
 
 const (
 	artifactsSection summarySection = "artifacts"
-	packagesSection                 = "packages"
-	buildInfoSection                = "build"
+	packagesSection  summarySection = "packages"
+	buildInfoSection summarySection = "buildInfo"
 )
 
 // addGitHubTrackingToUrl adds GitHub-related query parameters to a given URL if the GITHUB_WORKFLOW environment variable is set.
diff --git a/artifactory/utils/commandsummary/utils_test.go b/artifactory/utils/commandsummary/utils_test.go
@@ -71,7 +71,7 @@ func TestAddGitHubTrackingToUrl(t *testing.T) {
 			"https://example.com/path",
 			buildInfoSection,
 			"workflow123",
-			"https://example.com/path?gh_job_id=workflow123&gh_section=build",
+			"https://example.com/path?gh_job_id=workflow123&gh_section=buildInfo",
 			false,
 		},
 		{

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,8 @@ type summarySection string`
`45`	`45`
`46`	`46`	`const (`
`47`	`47`	`artifactsSection summarySection = "artifacts"`
`48`		`- packagesSection = "packages"`
`49`		`- buildInfoSection = "build"`
	`48`	`+ packagesSection summarySection = "packages"`
	`49`	`+ buildInfoSection summarySection = "buildInfo"`
`50`	`50`	`)`
`51`	`51`
`52`	`52`	`// addGitHubTrackingToUrl adds GitHub-related query parameters to a given URL if the GITHUB_WORKFLOW environment variable is set.`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ func TestAddGitHubTrackingToUrl(t *testing.T) {`
`71`	`71`	`"https://example.com/path",`
`72`	`72`	`buildInfoSection,`
`73`	`73`	`"workflow123",`
`74`		`- "https://example.com/path?gh_job_id=workflow123&gh_section=build",`
	`74`	`+ "https://example.com/path?gh_job_id=workflow123&gh_section=buildInfo",`
`75`	`75`	`false,`
`76`	`76`	`},`
`77`	`77`	`{`