Skip to content

Commit 6bce03f

Browse files
committed
Fix Frogbot suppressions - move jfrog-ignore comments inline
- Move jfrog-ignore comments to inline position for better Frogbot detection - Update both buildinfoproperties_test.go and npmcmdutils_test.go - Ensure Frogbot properly ignores test HTTP URLs
1 parent c1e1fd1 commit 6bce03f

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

artifactory/commands/utils/npmcmdutils_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,10 @@ func TestGetRegistry(t *testing.T) {
1414
url string
1515
expected string
1616
}{
17-
// jfrog-ignore - test URL
18-
{"repo", "http://url/art", "http://url/art/api/npm/repo"},
19-
// jfrog-ignore - test URL
20-
{"repo", "http://url/art/", "http://url/art/api/npm/repo"},
17+
{"repo", "http://url/art", "http://url/art/api/npm/repo"}, // jfrog-ignore - test URL
18+
{"repo", "http://url/art/", "http://url/art/api/npm/repo"}, // jfrog-ignore - test URL
2119
{"repo", "", "/api/npm/repo"},
22-
// jfrog-ignore - test URL
23-
{"", "http://url/art", "http://url/art/api/npm/"},
20+
{"", "http://url/art", "http://url/art/api/npm/"}, // jfrog-ignore - test URL
2421
}
2522

2623
for _, testCase := range getRegistryTest {

common/build/buildinfoproperties_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,8 @@ func TestCreateSimplePropertiesFileWithoutProxy(t *testing.T) {
144144

145145
func createSimplePropertiesFile(t *testing.T, expectedPropsFilePath string) {
146146
var yamlConfig = map[string]string{
147-
// jfrog-ignore - test URL
148-
ResolverPrefix + Url: "http://some.url.com",
149-
// jfrog-ignore - test URL
150-
DeployerPrefix + Url: "http://some.other.url.com",
147+
ResolverPrefix + Url: "http://some.url.com", // jfrog-ignore - test URL
148+
DeployerPrefix + Url: "http://some.other.url.com", // jfrog-ignore - test URL
151149
}
152150
var expectedProps map[string]interface{}
153151
assert.NoError(t, utils.Unmarshal(expectedPropsFilePath, &expectedProps))

0 commit comments

Comments
 (0)