Skip to content

Commit 877ca1d

Browse files
committed
CR changes
1 parent dc1405b commit 877ca1d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

common/commands/command.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ func Exec(command Command) error {
3939
return err
4040
}
4141

42-
// ExecAndReportUsage runs the command and then triggers a usage report if needed,
42+
// ExecAndThenReportUsage runs the command and then triggers a usage report
4343
// Is used for commands which don't have the full server details before execution
4444
// For example: oidc exchange command, which will get access token only after execution.
45-
func ExecAndReportUsage(cc Command) (err error) {
45+
func ExecAndThenReportUsage(cc Command) (err error) {
4646
if err = cc.Run(); err != nil {
4747
return
4848
}

common/commands/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ func exchangeOidcTokenAndSetAccessToken(cc *ConfigCommand) error {
234234
SetRunId(cc.oidcSetupParams.RunId)
235235

236236
// Usage report will be sent only after execution in order to have valid token
237-
err := ExecAndReportUsage(exchangeOidcTokenCmd)
237+
err := ExecAndThenReportUsage(exchangeOidcTokenCmd)
238238
if err != nil {
239239
return err
240240
}

general/token/oidctokenexchange.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ type OidcTokenParams struct {
5757
ProviderName string
5858
TokenId string
5959
Audience string
60-
// Those values are used to link the token to a specific use, they are optional
60+
// These values are used to link the token to a specific use, they are optional
6161
ProjectKey string
6262
ApplicationKey string
6363
JobId string

0 commit comments

Comments
 (0)