Skip to content

Commit c4b71b2

Browse files
committed
removing expectedOverride in tests as it is not supposed to be changed
1 parent b561ef9 commit c4b71b2

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

plugins/components/conversionlayer_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ func TestCreateCommandUsages(t *testing.T) {
1919
strFlag := NewStringFlag("flag", "", SetMandatory())
2020

2121
override := []string{"usage override", "usage override 2", "usage override 3"}
22-
expectedOverride := override
2322

2423
tests := []struct {
2524
name string
@@ -88,7 +87,7 @@ func TestCreateCommandUsages(t *testing.T) {
8887
UsageOptions: &UsageOptions{Usage: override},
8988
},
9089
stringFlags: map[string]StringFlag{optStrFlag.Name: optStrFlag},
91-
expected: append(expectedOverride,
90+
expected: append(override,
9291
fmt.Sprintf("%s [command options] <%s> <%s>", expectedPrefix, "first argument", "second"),
9392
fmt.Sprintf("%s [command options] --%s=<%s> <%s>", expectedPrefix, optStrFlag.Name, optStrFlag.HelpValue, "first argument"),
9493
),
@@ -102,7 +101,7 @@ func TestCreateCommandUsages(t *testing.T) {
102101
UsageOptions: &UsageOptions{Usage: override, ReplaceAutoGeneratedUsage: true},
103102
},
104103
stringFlags: map[string]StringFlag{optStrFlag.Name: optStrFlag, strFlag.Name: strFlag},
105-
expected: expectedOverride,
104+
expected: override, //override is not expected to be changed upon using UsageOptions
106105
},
107106
}
108107

0 commit comments

Comments
 (0)