Skip to content

Commit dde020e

Browse files
committed
Replace manual env var management with t.Setenv in Maven tests
- Replace originalHome pattern with t.Setenv in TestNewSettingsXmlManager - Replace originalHome pattern with t.Setenv in TestConfigureArtifactoryMirror_NoCredentials - Eliminates ignored errors from os.Setenv calls - Provides automatic cleanup and better error handling - Reduces code from 5 lines to 1 line per test function
1 parent 88532bb commit dde020e

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

artifactory/utils/maven/settingsxml_test.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,7 @@ func TestNewSettingsXmlManager(t *testing.T) {
2626
defer cleanupTempDir(t, tempDir)
2727

2828
// Set up a test home directory
29-
originalHome := os.Getenv("HOME")
30-
defer func() {
31-
_ = os.Setenv("HOME", originalHome)
32-
}()
33-
_ = os.Setenv("HOME", tempDir)
29+
t.Setenv("HOME", tempDir)
3430

3531
// Test with non-existing settings file
3632
manager, err := NewSettingsXmlManager()
@@ -309,11 +305,7 @@ func TestConfigureArtifactoryMirror_NoCredentials(t *testing.T) {
309305
defer cleanupTempDir(t, tempDir)
310306

311307
// Set up a test home directory
312-
originalHome := os.Getenv("HOME")
313-
defer func() {
314-
_ = os.Setenv("HOME", originalHome)
315-
}()
316-
_ = os.Setenv("HOME", tempDir)
308+
t.Setenv("HOME", tempDir)
317309

318310
manager, err := NewSettingsXmlManager()
319311
assert.NoError(t, err, "Failed to create manager")

0 commit comments

Comments
 (0)