remove todo

EyalDelarea · EyalDelarea · commit e5b0798d8657 · 2025-03-31T15:49:57.000+03:00
diff --git a/common/commands/config.go b/common/commands/config.go
@@ -507,8 +507,8 @@ func (cc *ConfigCommand) SetOidcExchangeTokenId(id string) {
 	cc.oidcSetupParams.TokenId = id
 }
 
+// Provider name must be set in order to use OIDC integration
 func (cc *ConfigCommand) UsesOidc() bool {
-	// TODO check if this is valid without checking the tpye as it defaults to github
 	return cc.oidcSetupParams.ProviderName != ""
 }
 

Original file line number	Diff line number	Diff line change
`@@ -507,8 +507,8 @@ func (cc *ConfigCommand) SetOidcExchangeTokenId(id string) {`
`507`	`507`	`cc.oidcSetupParams.TokenId = id`
`508`	`508`	`}`
`509`	`509`
	`510`	`+// Provider name must be set in order to use OIDC integration`
`510`	`511`	`func (cc *ConfigCommand) UsesOidc() bool {`
`511`		`- // TODO check if this is valid without checking the tpye as it defaults to github`
`512`	`512`	`return cc.oidcSetupParams.ProviderName != ""`
`513`	`513`	`}`
`514`	`514`