Fix WSL2 web login hanging issue by improving browser opening fallback#1429
Closed
gajeshbhat wants to merge 1 commit intojfrog:masterfrom
gajeshbhat:master
Closed
Fix WSL2 web login hanging issue by improving browser opening fallback#1429gajeshbhat wants to merge 1 commit intojfrog:masterfrom gajeshbhat:master
gajeshbhat wants to merge 1 commit intojfrog:masterfrom
gajeshbhat:master
Conversation
- Add graceful browser opening fallback for WSL2 environments - Display authentication URL prominently when browser fails to open - Add support for BROWSER and JFROG_CLI_BROWSER_COMMAND environment variables - Continue to token polling instead of exiting on browser failure - Add comprehensive unit tests for new browser handling logic Fixes #3008
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
Closing this Pull request for now. I think the workaround should be sufficient for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where
jf config addhangs indefinitely on WSL2 when using "Web Login" authentication method.Problem
In WSL2 environments, the
browser.OpenURL()function fails because there's no default browser configured. The original code treated this as a fatal error and exited immediately, causing the CLI to appear to hang since users never saw the authentication URL.Solution
BROWSER=none- Disables automatic browser openingJFROG_CLI_BROWSER_COMMAND- Allows custom browser command (e.g., Windows browser from WSL2)Changes
utils/coreutils/coreconsts.goto add browser command environment variableartifactory/utils/weblogin.gowith improved browser opening logicartifactory/utils/weblogin_test.goTesting
WSL2 Usage Examples
Closes
Fixes jfrog/jfrog-cli#3008
Files Summary: