Do not send empty filter criteria into deploy payload

Author: ehl-jf

.github/workflows/analysis.yml

@@ -21,4 +21,4 @@ jobs:
       - name: Static Code Analysis
         uses: golangci/golangci-lint-action@v6
         with:
-          version: latest
+          version: v1.63.4

commands/common/manifest_test.go

@@ -29,7 +29,7 @@ var manifestSample = &model.Manifest{
 		"hidden1": "hidden1.value",
 		"hidden2": "hidden2.value",
 	},
-	FilterCriteria: model.FilterCriteria{
+	FilterCriteria: &model.FilterCriteria{
 		ArtifactFilterCriteria: &model.ArtifactFilterCriteria{
 			RepoKeys: []string{
 				"my-repo-local",

commands/deploy_cmd.go

@@ -61,7 +61,7 @@ func GetDeployCommand() components.Command {
 				return err
 			}
 
-			if err = common.ValidateFilterCriteria(&manifest.FilterCriteria, actionMeta); err != nil {
+			if err = common.ValidateFilterCriteria(manifest.FilterCriteria, actionMeta); err != nil {
 				return err
 			}
 
@@ -149,7 +149,7 @@ func prepareDeployRequest(ctx *components.Context, manifest *model.Manifest, act
 	}
 
 	if actionMeta.MandatoryFilter {
-		payload.FilterCriteria = &manifest.FilterCriteria
+		payload.FilterCriteria = manifest.FilterCriteria
 	}
 
 	return payload, nil

commands/deploy_cmd_test.go

@@ -115,9 +115,11 @@ func TestDeployCommand(t *testing.T) {
 			workerName:     "wk-3",
 			serverBehavior: common.NewServerStub(t).WithGetOneEndpoint(),
 			patchManifest: func(mf *model.Manifest) {
-				mf.FilterCriteria.Schedule = &model.ScheduleFilterCriteria{
-					Cron:     "1h",
-					Timezone: "Asia/New_York",
+				mf.FilterCriteria = &model.FilterCriteria{
+					Schedule: &model.ScheduleFilterCriteria{
+						Cron:     "1h",
+						Timezone: "Asia/New_York",
+					},
 				}
 			},
 			wantErr: errors.New("manifest validation failed: invalid cron expression"),

commands/edit_schedule_cmd.go

@@ -59,7 +59,9 @@ func (c *editScheduleCommand) run() error {
 		return fmt.Errorf("invalid schedule provided: %w", err)
 	}
 
-	manifest.FilterCriteria.Schedule = newCriteria
+	manifest.FilterCriteria = &model.FilterCriteria{
+		Schedule: newCriteria,
+	}
 
 	if err = common.SaveManifest(manifest); err != nil {
 		return fmt.Errorf("failed to save manifest: %w", err)

model/manifest.go

@@ -20,14 +20,14 @@ type FilterCriteria struct {
 type Secrets map[string]string
 
 type Manifest struct {
-	Name           string         `json:"name"`
-	Description    string         `json:"description"`
-	SourceCodePath string         `json:"sourceCodePath"`
-	Action         string         `json:"action"`
-	Enabled        bool           `json:"enabled"`
-	Debug          bool           `json:"debug"`
-	ProjectKey     string         `json:"projectKey"`
-	Secrets        Secrets        `json:"secrets"`
-	FilterCriteria FilterCriteria `json:"filterCriteria,omitempty"`
-	Application    string         `json:"application,omitempty"`
+	Name           string          `json:"name"`
+	Description    string          `json:"description"`
+	SourceCodePath string          `json:"sourceCodePath"`
+	Action         string          `json:"action"`
+	Enabled        bool            `json:"enabled"`
+	Debug          bool            `json:"debug"`
+	ProjectKey     string          `json:"projectKey"`
+	Secrets        Secrets         `json:"secrets"`
+	FilterCriteria *FilterCriteria `json:"filterCriteria,omitempty"`
+	Application    string          `json:"application,omitempty"`
 }

model/worker.go

@@ -6,13 +6,13 @@ type Secret struct {
 	MarkedForRemoval bool   `json:"markedForRemoval"`
 }
 type WorkerDetails struct {
-	Key            string         `json:"key"`
-	Description    string         `json:"description"`
-	Debug          bool           `json:"debug"`
-	Enabled        bool           `json:"enabled"`
-	SourceCode     string         `json:"sourceCode"`
-	Action         string         `json:"action"`
-	FilterCriteria FilterCriteria `json:"filterCriteria,omitempty"`
-	Secrets        []*Secret      `json:"secrets"`
-	ProjectKey     string         `json:"projectKey"`
+	Key            string          `json:"key"`
+	Description    string          `json:"description"`
+	Debug          bool            `json:"debug"`
+	Enabled        bool            `json:"enabled"`
+	SourceCode     string          `json:"sourceCode"`
+	Action         string          `json:"action"`
+	FilterCriteria *FilterCriteria `json:"filterCriteria,omitempty"`
+	Secrets        []*Secret       `json:"secrets"`
+	ProjectKey     string          `json:"projectKey"`
 }

test/commands/list_cmd_test.go

@@ -53,7 +53,7 @@ func TestListCommand(t *testing.T) {
 			Enabled:     true,
 			SourceCode:  `export default async function() { return { "status": "OK" } }`,
 			Action:      "BEFORE_DOWNLOAD",
-			FilterCriteria: model.FilterCriteria{
+			FilterCriteria: &model.FilterCriteria{
 				ArtifactFilterCriteria: &model.ArtifactFilterCriteria{
 					RepoKeys: []string{"example-repo-local"},
 				},