Fix binary scan tests by creating config once in TestMain setup

The previous fix was creating/deleting config in each test, causing race
conditions when tests ran in parallel or sequentially. Docker tests work
by creating isolated config directories per test via InitTestWithMockCommandOrParams.

This fix creates the CLI config ONCE in setupIntegrationTests() so all
binary scan tests share the same config, preventing conflicts.

Root cause:
- CreateJfrogHomeConfig deletes and recreates the 'default' config
- Calling it in each test caused tests to interfere with each other
- Docker tests avoid this by using isolated config directories per test

Solution:
- Move CreateJfrogHomeConfig call to setupIntegrationTests()
- Only create config when --test.scan flag is set
- Remove individual CreateJfrogHomeConfig calls from all 9 binary scan tests

Author: agrasth

jfrogclisecurity_test.go

@@ -42,6 +42,10 @@ func setupIntegrationTests() {
 	integrationUtils.AuthenticateArtifactory()
 	integrationUtils.AuthenticateXsc()
 	integrationUtils.CreateRequiredRepositories()
+	// Create CLI config for binary scan tests (Docker tests create their own isolated configs)
+	if *configTests.TestScan {
+		integrationUtils.CreateJfrogHomeConfig(nil, "", true)
+	}
 }
 
 func tearDownIntegrationTests() {

scans_test.go

@@ -98,7 +98,6 @@ func runXrayBinaryScan(t *testing.T, params binaryScanParams) (string, error) {
 // Binary scan tests
 func TestXrayBinaryScanJson(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	output := testXrayMultipleBinariesScan(t, binaryScanParams{Format: format.Json, WithLicense: true}, false)
 	validations.VerifyJsonResults(t, output, validations.ValidationParams{
 		Total: &validations.TotalCount{Licenses: 1, Vulnerabilities: 1},
@@ -107,7 +106,6 @@ func TestXrayBinaryScanJson(t *testing.T) {
 
 func TestXrayBinaryScanSimpleJson(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	output := testXrayBinaryScanWithWatch(t, format.SimpleJson, "xray-scan-binary-policy", "scan-binary-watch", true)
 	validations.VerifySimpleJsonResults(t, output, validations.ValidationParams{
 		Total: &validations.TotalCount{Licenses: 1, Vulnerabilities: 1, Violations: 1},
@@ -116,7 +114,6 @@ func TestXrayBinaryScanSimpleJson(t *testing.T) {
 
 func TestXrayBinaryScanCycloneDx(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	output := testXrayBinaryScanJASArtifact(t, format.CycloneDx, "backupfriend-client.tar.gz", false)
 	validations.VerifyCycloneDxResults(t, output, validations.ValidationParams{
 		Total: &validations.TotalCount{Vulnerabilities: 4},
@@ -129,7 +126,6 @@ func TestXrayBinaryScanCycloneDx(t *testing.T) {
 
 func TestXrayBinaryScanJsonDocker(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	// In Windows, indexer fails to index the tar, Caused by: failed to rename path for layer so we run in clean copy in temp dir
 	output := testXrayBinaryScanJASArtifact(t, format.SimpleJson, "xmas.tar", true)
 	validations.VerifySimpleJsonResults(t, output, validations.ValidationParams{
@@ -143,7 +139,6 @@ func TestXrayBinaryScanJsonDocker(t *testing.T) {
 
 func TestXrayBinaryScanJsonGeneric(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	output := testXrayBinaryScanJASArtifact(t, format.SimpleJson, "backupfriend-client.tar.gz", false)
 	validations.VerifySimpleJsonResults(t, output, validations.ValidationParams{
 		Total: &validations.TotalCount{Vulnerabilities: 4},
@@ -156,7 +151,6 @@ func TestXrayBinaryScanJsonGeneric(t *testing.T) {
 
 func TestXrayBinaryScanJsonJar(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	output := testXrayBinaryScanJASArtifact(t, format.SimpleJson, "student-services-security-0.0.1.jar", false)
 	validations.VerifySimpleJsonResults(t, output, validations.ValidationParams{
 		Total: &validations.TotalCount{Vulnerabilities: 41},
@@ -169,7 +163,6 @@ func TestXrayBinaryScanJsonJar(t *testing.T) {
 
 func TestXrayBinaryScanJsonWithProgress(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	callback := commonTests.MockProgressInitialization()
 	defer callback()
 	output := testXrayMultipleBinariesScan(t, binaryScanParams{Format: format.Json, WithLicense: true}, false)
@@ -180,7 +173,6 @@ func TestXrayBinaryScanJsonWithProgress(t *testing.T) {
 
 func TestXrayBinaryScanSimpleJsonWithProgress(t *testing.T) {
 	integration.InitScanTest(t, scangraph.GraphScanMinXrayVersion)
-	integration.CreateJfrogHomeConfig(t, "", true)
 	callback := commonTests.MockProgressInitialization()
 	defer callback()
 	output := testXrayBinaryScanWithWatch(t, format.SimpleJson, "xray-scan-binary-progress-policy", "scan-binary-progress-watch", true)