CR changes

Author: attiasas

commands/audit/audit_test.go

@@ -613,7 +613,6 @@ func TestAuditWithConfigProfile(t *testing.T) {
 				SetXscVersion(services.ConfigProfileMinXscVersion).
 				SetOutputFormat(format.Table).
 				SetUseJas(true).
-				SetIsRecursiveScan(true).
 				SetConfigProfile(&configProfile)
 
 			auditParams := NewAuditParams().

tests/utils/integration/test_integrationutils.go

@@ -521,12 +521,10 @@ func InitTestHomeResources() (cleanUp func()) {
 }
 
 func PrepareJfrogHomeResources(details *config.ServerDetails) (err error) {
-	// Prepare the Analyzer Manager resource.
 	if err = testUtils.PrepareAnalyzerManagerResource(); err != nil {
 		return fmt.Errorf("failed to prepare analyzer manager resource: %w", err)
 	}
-	// Prepare the Xray Indexer resource.
-	if err = testUtils.PrepareIndexerResource(details); err != nil {
+	if err = testUtils.PrepareIndexerAppResource(details); err != nil {
 		return fmt.Errorf("failed to prepare Xray Indexer resource: %w", err)
 	}
 	return

tests/utils/test_utils.go

@@ -432,24 +432,21 @@ func CreateTestProjectFromZipAndChdir(t *testing.T, projectPath string) (string,
 // Make sure to call this function before running any tests that require the analyzer manager binary.
 func PrepareAnalyzerManagerResource() (err error) {
 	if localPath := os.Getenv(configTests.TestJfrogLocalAnalyzerManagerDirEnvVar); localPath != "" {
-		// Copy the analyzer manager binary to the current JFrog Home.
 		amLocalPath, err := jas.GetAnalyzerManagerDirAbsolutePath()
 		if err != nil {
 			return fmt.Errorf("failed to get analyzer manager local path: %w", err)
 		}
-		// if exists, no need to copy
 		if exist, err := fileutils.IsDirExists(amLocalPath, false); err != nil || exist {
 			return err
 		}
 		if err := biutils.CopyDir(localPath, amLocalPath, true, []string{}); err != nil {
 			return fmt.Errorf("failed to copy analyzer manager from %s to %s: %w", localPath, amLocalPath, err)
 		}
 	}
-	// Download the analyzer manager binary if it doesn't exist to current JFrog Home.
 	return jas.DownloadAnalyzerManagerIfNeeded(0)
 }
 
-func PrepareIndexerResource(details *config.ServerDetails) (err error) {
+func PrepareIndexerAppResource(details *config.ServerDetails) (err error) {
 	manager, version, err := xrayUtils.CreateXrayServiceManagerAndGetVersion(details)
 	if err != nil {
 		return fmt.Errorf("failed to create Xray service manager: %w", err)

tests/validations/test_validation.go

@@ -394,6 +394,7 @@ func ValidateCommandOutput(t *testing.T, output string, outFormat format.OutputF
 	case format.CycloneDx:
 		VerifyCycloneDxResults(t, output, params)
 	default:
+		// SARIF format is not supported for validations (not implemented)
 		t.Fatalf("Unsupported output format: %s", outFormat)
 	}
 }

xsc_test.go

@@ -47,6 +47,7 @@ func TestXscAuditNpmJsonWithWatch(t *testing.T) {
 			format:   format.SimpleJson,
 			withVuln: true,
 		},
+		// SARIF format is not supported for validations (not implemented)
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {