Skip to content

Conversation

@hadarshjfrog
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Based on PR by @attiasas - added the AM to support the addition of "JFrog SAST" when using sarif format

@hadarshjfrog hadarshjfrog changed the title Add sast flag if sarif am 199 Add sast flag if sarif am 1.9.8 Oct 20, 2024
@hadarshjfrog hadarshjfrog changed the title Add sast flag if sarif am 1.9.8 Add sast flag if sarif - AM 1.9.8 Oct 20, 2024
Roots: roots,
Language: sastScanner.Language,
ExcludedRules: sastScanner.ExcludedRules,
SastParameters: sastParameters{SignedDescriptions: signedDescriptions},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking whether we should add "SastParameters" under "SastScanManager" too

@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@hadarshjfrog hadarshjfrog added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Oct 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 22, 2024
@attiasas
Copy link
Contributor

Duplicate of: #206

@attiasas attiasas closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants