Add test case for multiple image tags in build-docker-create

Author: agrasth

docker_test.go

@@ -287,6 +287,98 @@ func TestPushFatManifestImage(t *testing.T) {
 	assert.True(t, totalResults > 1)
 }
 
+func TestPushMultiTaggedImage(t *testing.T) {
+	if !*tests.TestDocker {
+		t.Skip("Skipping test. To run it, add the '-test.docker=true' option.")
+	}
+
+	buildName := "push-multi-tagged" + tests.DockerBuildName
+	buildNumber := "1"
+
+	// Setup workspace
+	workspace, err := filepath.Abs(tests.Out)
+	assert.NoError(t, err)
+	assert.NoError(t, fileutils.CreateDirIfNotExist(workspace))
+	testDataDir := filepath.Join(filepath.FromSlash(tests.GetTestResourcesPath()), "docker")
+	files, err := os.ReadDir(testDataDir)
+	assert.NoError(t, err)
+	for _, file := range files {
+		if !file.IsDir() {
+			_, err := tests.ReplaceTemplateVariables(filepath.Join(testDataDir, file.Name()), tests.Out)
+			assert.NoError(t, err)
+		}
+	}
+
+	// Build the builder image locally
+	ctx := context.Background()
+	testContainer, err := tests.NewContainerRequest().
+		SetDockerfile(workspace, "Dockerfile.Buildx.Fatmanifest", nil).
+		Privileged().
+		Networks(rtNetwork).
+		Name("buildx_multi_tag_container").
+		Mount(mount.Mount{Type: mount.TypeBind, Source: workspace, Target: "/workspace", ReadOnly: false}).
+		Cmd("--insecure-registry", tests.RtContainerHostName).
+		WaitFor(wait.ForLog("API listen on /var/run/docker.sock").WithStartupTimeout(5*time.Minute)).
+		Remove().
+		Build(ctx, true)
+	assert.NoError(t, err, "Couldn't create buildx container.")
+	defer func() { assert.NoError(t, testContainer.Terminate(ctx)) }()
+
+	// Enable builder
+	assert.NoError(t, testContainer.Exec(ctx, "sh", "script.sh"))
+
+	// Login to Artifactory
+	password := *tests.JfrogPassword
+	user := *tests.JfrogUser
+	if *tests.JfrogAccessToken != "" {
+		user = auth.ExtractUsernameFromAccessToken(*tests.JfrogAccessToken)
+		password = *tests.JfrogAccessToken
+	}
+	assert.NoError(t, testContainer.Exec(
+		ctx,
+		"docker", "login",
+		tests.RtContainerHostName,
+		"--username="+user,
+		"--password="+password))
+
+	// Build & push image with multiple tags
+	imageName1 := path.Join(tests.RtContainerHostName, tests.DockerLocalRepo, tests.DockerImageName+"-multi:v1")
+	imageName2 := path.Join(tests.RtContainerHostName, tests.DockerLocalRepo, tests.DockerImageName+"-multi:latest")
+	buildxOutputFile := "multi-build-metadata"
+
+	assert.NoError(t, testContainer.Exec(
+		ctx,
+		"docker", "buildx", "build",
+		"--platform", "linux/amd64,linux/arm64",
+		"-t", imageName1,
+		"-t", imageName2,
+		"-f", "Dockerfile.Fatmanifest",
+		"--metadata-file", "/workspace/"+buildxOutputFile,
+		"--push", ".",
+	))
+
+	// Run build-docker-create & publish
+	buildxOutput := filepath.Join(workspace, buildxOutputFile)
+	assert.NoError(t, artifactoryCli.Exec("build-docker-create", tests.DockerLocalRepo, "--image-file="+buildxOutput, "--build-name="+buildName, "--build-number="+buildNumber))
+	assert.NoError(t, artifactoryCli.Exec("build-publish", buildName, buildNumber))
+
+	// Validate build-info is published
+	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, buildName, buildNumber)
+	assert.NoError(t, err)
+	assert.True(t, found, "build info was expected to be found")
+	assert.True(t, len(publishedBuildInfo.BuildInfo.Modules) >= 1)
+
+	// Validate build-name & build-number properties in all layers
+	searchSpec := spec.NewBuilder().Pattern(tests.DockerLocalRepo + "/*").Build(buildName).Recursive(true).BuildSpec()
+	searchCmd := generic.NewSearchCommand()
+	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
+	reader, err := searchCmd.Search()
+	assert.NoError(t, err)
+	totalResults, err := reader.Length()
+	assert.NoError(t, err)
+	assert.True(t, totalResults > 1)
+}
+
 func TestContainerPushMultipleImages(t *testing.T) {
 	containerManagers := initContainerTest(t)
 	imageNames := []string{