try fix docker integration tests

Author: attiasas

buildtools/cli.go

@@ -977,11 +977,6 @@ func dockerScanCmd(c *cli.Context, imageTag string) error {
 	if show, err := cliutils.ShowGenericCmdHelpIfNeeded(c, c.Args(), securityCLI.DockerScanCmdHiddenName); show || err != nil {
 		return err
 	}
-	if imageTag == "" {
-		return commonCliUtils.PrintHelpAndReturnError("a docker image name must be provided", func() error {
-			return cli.ShowCommandHelp(c, securityCLI.DockerScanCmdHiddenName)
-		})
-	}
 	convertedCtx, err := components.ConvertContext(c, securityDocs.GetCommandFlags(securityDocs.DockerScan)...)
 	if err != nil {
 		return err

docker_test.go

@@ -2,8 +2,8 @@ package main
 
 import (
 	"context"
+	"errors"
 	"fmt"
-	tests2 "github.com/jfrog/jfrog-cli-artifactory/utils/tests"
 	"os"
 	"os/exec"
 	"path"
@@ -12,6 +12,8 @@ import (
 	"testing"
 	"time"
 
+	tests2 "github.com/jfrog/jfrog-cli-artifactory/utils/tests"
+
 	"github.com/docker/docker/api/types/mount"
 
 	biutils "github.com/jfrog/build-info-go/utils"
@@ -601,17 +603,23 @@ func TestNativeDockerFlagParsing(t *testing.T) {
 	defer cleanup()
 
 	dockerTestCases := []struct {
-		name string
-		args []string
+		name        string
+		args        []string
+		expectedErr error
 	}{
-		{"docker", []string{"docker"}},
-		{"docker version", []string{"docker", "version"}},
-		{"docker scan", []string{"docker", "scan"}},
-		{"cli flags after args", []string{"docker", "version", "--build-name=d", "--build-number=1", "--module=1"}},
-		{"cli flags before args", []string{"docker", "--build-name=d", "--build-number=1", "--module=1", "version"}},
+		{"docker", []string{"docker"}, nil},
+		{"docker version", []string{"docker", "version"}, nil},
+		{"docker scan", []string{"docker", "scan", "--min-severity=low"}, errors.New("a docker image name must be provided")},
+		{"cli flags after args", []string{"docker", "version", "--build-name=d", "--build-number=1", "--module=1"}, nil},
+		{"cli flags before args", []string{"docker", "--build-name=d", "--build-number=1", "--module=1", "version"}, nil},
 	}
 	for _, testCase := range dockerTestCases {
 		t.Run(testCase.name, func(t *testing.T) {
+			if testCase.expectedErr != nil {
+				err := runJfrogCliWithoutAssertion(testCase.args...)
+				assert.EqualError(t, err, testCase.expectedErr.Error())
+				return
+			}
 			runCmdWithRetries(t, jfCliTask(testCase.args...))
 		})
 	}