Feature/add properties for repository via j frog cli (#1148)

Added feature for setting properties for repo-only

---------

Co-authored-by: Eyal Delarea <eyalde@jfrog.com>

Author: naveenku-jfrog

artifactory/services/props.go

@@ -45,7 +45,13 @@ func (ps *PropsService) GetThreads() int {
 
 func (ps *PropsService) SetProps(propsParams PropsParams) (int, error) {
 	log.Info("Setting properties...")
-	totalSuccess, err := ps.performRequest(propsParams, false)
+	var err error
+	var totalSuccess int
+	if propsParams.RepoOnly {
+		totalSuccess, err = ps.performRequestForRepoOnly(propsParams, false)
+	} else {
+		totalSuccess, err = ps.performRequest(propsParams, false)
+	}
 	if err == nil {
 		log.Info("Done setting properties.")
 	}
@@ -54,16 +60,23 @@ func (ps *PropsService) SetProps(propsParams PropsParams) (int, error) {
 
 func (ps *PropsService) DeleteProps(propsParams PropsParams) (int, error) {
 	log.Info("Deleting properties...")
-	totalSuccess, err := ps.performRequest(propsParams, true)
+	var err error
+	var totalSuccess int
+	if propsParams.RepoOnly {
+		totalSuccess, err = ps.performRequestForRepoOnly(propsParams, true)
+	} else {
+		totalSuccess, err = ps.performRequest(propsParams, true)
+	}
 	if err == nil {
 		log.Info("Done deleting properties.")
 	}
 	return totalSuccess, err
 }
 
 type PropsParams struct {
-	Reader *content.ContentReader
-	Props  string
+	Reader   *content.ContentReader
+	Props    string
+	RepoOnly bool
 }
 
 func (sp *PropsParams) GetReader() *content.ContentReader {
@@ -74,6 +87,88 @@ func (sp *PropsParams) GetProps() string {
 	return sp.Props
 }
 
+func (ps *PropsService) getEncodedParam(propsParams PropsParams, isDelete bool) (string, error) {
+	var encodedParam string
+	if !isDelete {
+		props, err := utils.ParseProperties(propsParams.GetProps())
+		if err != nil {
+			return "", err
+		}
+		encodedParam = props.ToEncodedString(true)
+	} else {
+		propList := strings.Split(propsParams.GetProps(), ",")
+		for _, prop := range propList {
+			encodedParam += url.QueryEscape(prop) + ","
+		}
+		// Remove trailing comma
+		encodedParam = strings.TrimSuffix(encodedParam, ",")
+	}
+	return encodedParam, nil
+}
+
+func (ps *PropsService) addOrDeletePropertiesForRepo(propsParams PropsParams, isDelete bool, encodedParam string) (int, error) {
+	var action func(string, string, string) (*http.Response, []byte, error)
+	if isDelete {
+		action = ps.sendDeleteRequest
+	} else {
+		action = ps.sendPutRequest
+	}
+	successCounters := make([]int, ps.GetThreads())
+	producerConsumer := parallel.NewBounedRunner(ps.GetThreads(), false)
+	errorsQueue := clientutils.NewErrorsQueue(1)
+	reader := propsParams.GetReader()
+	resultItem := new(utils.ResultItem)
+	if reader.NextRecord(resultItem) == nil {
+		repoName := resultItem.Repo
+		setPropsTask := func(threadId int) error {
+			var err error
+			logMsgPrefix := clientutils.GetLogMsgPrefix(threadId, ps.IsDryRun())
+
+			restAPI := path.Join("api", "storage", repoName)
+			setPropertiesURL, err := clientutils.BuildUrl(ps.GetArtifactoryDetails().GetUrl(), restAPI, make(map[string]string))
+			if err != nil {
+				return err
+			}
+			// Because we do set/delete props on search results that took into account the
+			// recursive flag, we do not want the action itself to be recursive.
+			setPropertiesURL += "?properties=" + encodedParam + "&recursive=0"
+			resp, body, err := action(logMsgPrefix, repoName, setPropertiesURL)
+
+			if err != nil {
+				return err
+			}
+			if err = errorutils.CheckResponseStatusWithBody(resp, body, http.StatusNoContent); err != nil {
+				return err
+			}
+			successCounters[threadId]++
+			return nil
+		}
+
+		_, _ = producerConsumer.AddTaskWithError(setPropsTask, errorsQueue.AddError)
+	}
+
+	defer producerConsumer.Done()
+	if err := reader.GetError(); err != nil {
+		errorsQueue.AddError(err)
+	}
+	reader.Reset()
+	producerConsumer.Run()
+	totalSuccess := 0
+	for _, v := range successCounters {
+		totalSuccess += v
+	}
+	return totalSuccess, errorsQueue.GetError()
+}
+
+func (ps *PropsService) performRequestForRepoOnly(propsParams PropsParams, isDelete bool) (int, error) {
+	encodedParam, err := ps.getEncodedParam(propsParams, isDelete)
+	if err != nil {
+		return 0, err
+	}
+
+	return ps.addOrDeletePropertiesForRepo(propsParams, isDelete, encodedParam)
+}
+
 func (ps *PropsService) performRequest(propsParams PropsParams, isDelete bool) (int, error) {
 	var encodedParam string
 	if !isDelete {

lifecycle/services/delete.go

@@ -46,6 +46,7 @@ func (rbs *ReleaseBundlesService) deleteReleaseBundle(params CommonOptionalQuery
 	return errorutils.CheckResponseStatusWithBody(resp, body, http.StatusNoContent)
 }
 
+
 func (rbs *ReleaseBundlesService) RemoteDeleteReleaseBundle(rbDetails ReleaseBundleDetails, params ReleaseBundleRemoteDeleteParams, isNewReleaseBundleApiSupported bool) error {
 	dryRunStr := ""
 	if params.DryRun {
@@ -59,6 +60,7 @@ func (rbs *ReleaseBundlesService) RemoteDeleteReleaseBundle(rbDetails ReleaseBun
 		return errorutils.CheckError(err)
 	}
 
+
 	restApi := GetRemoteDeleteReleaseBundleApi(rbDetails, isNewReleaseBundleApiSupported)
 	requestFullUrl, err := utils.BuildUrl(rbs.GetLifecycleDetails().GetUrl(), restApi, nil)
 	if err != nil {