Skip to content

Source selector fails to initialize when the full-screen toggle is disabled #52

@yurique

Description

@yurique

I have full-screen button disabled and getting an exception like this in the console:

VIDEOJS: ERROR: TypeError: Cannot read property 'el' of undefined

I believe the root of the issue is here:

      player.videojs_http_source_selector_initialized = true;
      var controlBar = player.controlBar,
          fullscreenToggle = controlBar.getChild('fullscreenToggle').el();
      controlBar.el().insertBefore(controlBar.addChild('SourceMenuButton').el(), fullscreenToggle);

Changing it to

        var controlBar = player.controlBar,
            fullscreenToggle = controlBar.getChild('fullscreenToggle');
        if (fullscreenToggle) {
          controlBar.el().insertBefore(controlBar.addChild('SourceMenuButton').el(), fullscreenToggle.el());
        } else {
          controlBar.el().appendChild(controlBar.addChild('SourceMenuButton').el());
        }

Fixes the issue, I'll open a PR in a sec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions