From f2597ce5f0f9d45f67f1ea3c1dd3f028d6532da9 Mon Sep 17 00:00:00 2001 From: Iurii Malchenko Date: Mon, 27 Apr 2020 12:24:41 +0300 Subject: [PATCH 1/2] =?UTF-8?q?fixing=20#52=20-=20Source=20selector=20fail?= =?UTF-8?q?s=20to=20initialize=E2=80=A6..?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …when the full-screen toggle is disabled --- src/plugin.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/plugin.js b/src/plugin.js index e33911c..906bfbe 100644 --- a/src/plugin.js +++ b/src/plugin.js @@ -55,8 +55,14 @@ const onPlayerReady = (player, options) => { console.log("player.videojs_http_source_selector_initialized == false") player.videojs_http_source_selector_initialized = true; - var controlBar = player.controlBar, - fullscreenToggle = controlBar.getChild('fullscreenToggle').el(); + + var controlBar = player.controlBar, + fullscreenToggle = controlBar.getChild('fullscreenToggle'); + if (fullscreenToggle) { + controlBar.el().insertBefore(controlBar.addChild('SourceMenuButton').el(), fullscreenToggle.el()); + } else { + controlBar.el().appendChild(controlBar.addChild('SourceMenuButton').el()); + } controlBar.el().insertBefore(controlBar.addChild('SourceMenuButton').el(), fullscreenToggle); } }); From ffa41b11f63d87a477966ce15cf7cd9a6040f10b Mon Sep 17 00:00:00 2001 From: Iurii Malchenko Date: Mon, 27 Apr 2020 12:27:04 +0300 Subject: [PATCH 2/2] forgot to remove the old insert --- src/plugin.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugin.js b/src/plugin.js index 906bfbe..3371e7f 100644 --- a/src/plugin.js +++ b/src/plugin.js @@ -55,7 +55,6 @@ const onPlayerReady = (player, options) => { console.log("player.videojs_http_source_selector_initialized == false") player.videojs_http_source_selector_initialized = true; - var controlBar = player.controlBar, fullscreenToggle = controlBar.getChild('fullscreenToggle'); if (fullscreenToggle) { @@ -63,7 +62,6 @@ const onPlayerReady = (player, options) => } else { controlBar.el().appendChild(controlBar.addChild('SourceMenuButton').el()); } - controlBar.el().insertBefore(controlBar.addChild('SourceMenuButton').el(), fullscreenToggle); } }); };