Merge pull request #168 from jgphilpott/copilot/fix-support-generation-issue

jgphilpott · web-flow · commit 3027ac37e4d1 · 2026-03-02T11:35:07.000+03:00
Fix case-insensitive input handling for all string setters in accessors
diff --git a/resources/gcode/support/normal/dome/flipped.gcode b/resources/gcode/support/normal/dome/flipped.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:52f1c2032679a1c0bca31d1c3b4bde55de0ac51d3da6dc3545f3b21c04051efe
+oid sha256:b704960ac6c0006b90f51305970276a5cb65cdcca8310c3d54796ef4f74a323c
 size 774608
diff --git a/resources/gcode/support/normal/dome/sideways-buildPlate.gcode b/resources/gcode/support/normal/dome/sideways-buildPlate.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e3ab6491239247e02c0d5cd63f2528120066a41e1a0af85ce1f6126843116ddd
-size 967277
+oid sha256:d7d21441a0cbe40c5f3f40621bb74751362854320b6636c700d4298be61c891e
+size 679823
diff --git a/resources/gcode/support/threshold/0-degrees.gcode b/resources/gcode/support/threshold/0-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9425fa24fd10c4960f8b47de52cc5da0e78e9895a10ab391737696c964e98b17
-size 1724467
+oid sha256:826cbaa15054dbf9f35485fbe4a198e394896c8e48f5d7d2dc5f07ca6fffbe0c
+size 1721749
diff --git a/resources/gcode/support/threshold/10-degrees.gcode b/resources/gcode/support/threshold/10-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5ffd3895f813d0904acf2fc523ff19d5c248268a8085206b8f256bb7a3088189
-size 1710201
+oid sha256:070e225edf91dd2e6b793eb06fe9eacf0c7dad3a33c7fe7e3039211c5526f9df
+size 1707502
diff --git a/resources/gcode/support/threshold/20-degrees.gcode b/resources/gcode/support/threshold/20-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:371744a96c7a4337d8cb2a2f83a8c31e023b8db653cca16b288b99c0579583fe
-size 1637040
+oid sha256:9817469f3826561213bc030298787a134e771d30e97b57c4a5181e1a98e2e6b4
+size 1634243
diff --git a/resources/gcode/support/threshold/30-degrees.gcode b/resources/gcode/support/threshold/30-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:69712227cd309fb181ff885c030f2f38a96e38c3512298e855a6d46af1c4b8b7
-size 1516490
+oid sha256:f2e7cbc0ba12f239d4d74abcbd9a11ff57a91f126479bdd5b7b2ee986ad83f92
+size 1513767
diff --git a/resources/gcode/support/threshold/40-degrees.gcode b/resources/gcode/support/threshold/40-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:eee122e5452bdb758b24bde5097ca08a515f8b55bcbb80bb3cf6ce21a831f820
-size 1361458
+oid sha256:6e4c1612819359a84c80cdb726f39855f26058d5f0acf5471415137367b5d1df
+size 1358777
diff --git a/resources/gcode/support/threshold/50-degrees.gcode b/resources/gcode/support/threshold/50-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cf21ea4c5f89a3f644be42b1f4d546340639486b9e3eb51c59dc595cb0ebe399
-size 1109440
+oid sha256:c7086082b4e12d2dd6297d9fec99ffa7c5efdd64a5998baedaa6897f0dbf93bb
+size 1106710
diff --git a/resources/gcode/support/threshold/60-degrees.gcode b/resources/gcode/support/threshold/60-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3117f8425894f05030b68c2be44c66027b58ade6036595cf7cd268f74ef713ee
-size 966074
+oid sha256:7881fcffd86121e2803d293d61d18f5f199062de8ba3d7c0434b683f62272149
+size 963380
diff --git a/resources/gcode/support/threshold/70-degrees.gcode b/resources/gcode/support/threshold/70-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e558007e7063c21a306c433b63fd0bc44e3cf5732e8545756a36f3eb4bb99746
-size 857174
+oid sha256:6d36817d83f574f9f64885466bfb4358812e7950d7c4892ff8a41572717bdec9
+size 854572
diff --git a/resources/gcode/support/threshold/80-degrees.gcode b/resources/gcode/support/threshold/80-degrees.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:eaa554f8e31425db39d7be02edb4f7a08d0cf6567086b40ec52e2366fb20b81d
-size 799395
+oid sha256:e96c4a44d1996e3572b616786bb5e1a1ba0f6f4a7152b0908895ccc31ccaab83
+size 796627
diff --git a/resources/gcode/support/tree/arch/sideways-buildPlate.gcode b/resources/gcode/support/tree/arch/sideways-buildPlate.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:82b500144cb4040f69a0c6da86834208c1ded4859931460fe447cd5352baf01c
-size 762472
+oid sha256:12e955be0eb37bbdc855f0e6c1cb7d69f46ebb6937fbb15cb65b474a2e7c9004
+size 292025
diff --git a/resources/gcode/support/tree/dome/sideways-buildPlate.gcode b/resources/gcode/support/tree/dome/sideways-buildPlate.gcode
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:dcda6766bdfef57bcaf8650c2befb16a91bb344e51a0f474d40c939279cc690f
-size 942936
+oid sha256:5a507959b5fab34ae72ec2addab8fad0104dabafd5265fe19d602b16886fabfb
+size 679759
diff --git a/src/slicer/support/support.test.coffee b/src/slicer/support/support.test.coffee
@@ -97,6 +97,20 @@ describe 'Support Module', ->
 
             expect(result).toBeUndefined()
 
+        test 'should allow switching supportPlacement from everywhere back to buildPlate', ->
+
+            # Setting to 'everywhere' then back to 'buildPlate' must persist correctly.
+            # Regression test for bug where setSupportPlacement('buildPlate') silently
+            # failed because toLowerCase() turned 'buildPlate' into 'buildplate' which
+            # did not match the validation array ["everywhere", "buildPlate"].
+            slicer.setSupportPlacement('everywhere')
+
+            expect(slicer.getSupportPlacement()).toBe('everywhere')
+
+            slicer.setSupportPlacement('buildPlate')
+
+            expect(slicer.getSupportPlacement()).toBe('buildPlate')
+
         test 'should use supportThreshold for overhang detection', ->
 
             slicer.setSupportEnabled(true)
diff --git a/src/utils/accessors.coffee b/src/utils/accessors.coffee
@@ -370,9 +370,19 @@ module.exports =
 
     setSpeedUnit: (slicer, unit = "millimeterSecond") ->
 
-        if ["millimeterSecond", "inchSecond", "meterSecond"].includes unit
+        normalized = unit.toLowerCase().trim()
 
-            slicer.speedUnit = String unit
+        if normalized is "millimetersecond"
+
+            slicer.speedUnit = "millimeterSecond"
+
+        else if normalized is "inchsecond"
+
+            slicer.speedUnit = "inchSecond"
+
+        else if normalized is "metersecond"
+
+            slicer.speedUnit = "meterSecond"
 
         return slicer
 
@@ -582,11 +592,15 @@ module.exports =
 
     setSupportPlacement: (slicer, placement = "buildPlate") ->
 
-        placement = placement.toLowerCase().trim()
+        normalized = placement.toLowerCase().trim()
 
-        if ["everywhere", "buildPlate"].includes placement
+        if normalized is "buildplate"
 
-            slicer.supportPlacement = String placement
+            slicer.supportPlacement = "buildPlate"
+
+        else if normalized is "everywhere"
+
+            slicer.supportPlacement = "everywhere"
 
         return slicer
 
@@ -904,6 +918,8 @@ module.exports =
 
     setPositioningMode: (slicer, mode = "absolute") ->
 
+        mode = mode.toLowerCase().trim()
+
         if ["absolute", "relative"].includes mode
 
             slicer.positioningMode = String mode
@@ -912,6 +928,8 @@ module.exports =
 
     setExtruderMode: (slicer, mode = "absolute") ->
 
+        mode = mode.toLowerCase().trim()
+
         if ["absolute", "relative"].includes mode
 
             slicer.extruderMode = String mode
diff --git a/src/utils/accessors.test.coffee b/src/utils/accessors.test.coffee
@@ -55,6 +55,30 @@ describe 'Accessors (Getters and Setters)', ->
             slicer.setAngleUnit('invalid')
             expect(slicer.getAngleUnit()).toBe('degree') # unchanged.
 
+        test 'should set and get speed unit', ->
+
+            expect(slicer.getSpeedUnit()).toBe('millimeterSecond')
+
+            slicer.setSpeedUnit('inchSecond')
+            expect(slicer.getSpeedUnit()).toBe('inchSecond')
+
+            slicer.setSpeedUnit('meterSecond')
+            expect(slicer.getSpeedUnit()).toBe('meterSecond')
+
+            slicer.setSpeedUnit('millimeterSecond')
+            expect(slicer.getSpeedUnit()).toBe('millimeterSecond')
+
+            # Should ignore invalid values.
+            slicer.setSpeedUnit('invalid')
+            expect(slicer.getSpeedUnit()).toBe('millimeterSecond') # unchanged.
+
+            # Should accept any capitalization and store canonical camelCase form.
+            slicer.setSpeedUnit('MILLIMETERSECOND')
+            expect(slicer.getSpeedUnit()).toBe('millimeterSecond')
+
+            slicer.setSpeedUnit('InchSecond')
+            expect(slicer.getSpeedUnit()).toBe('inchSecond')
+
     describe 'Temperature Accessors', ->
 
         test 'should set and get temperatures', ->
@@ -774,6 +798,13 @@ describe 'Accessors (Getters and Setters)', ->
             slicer.setPositioningMode('invalid')
             expect(slicer.getPositioningMode()).toBe('absolute') # unchanged.
 
+            # Should accept any capitalization.
+            slicer.setPositioningMode('Relative')
+            expect(slicer.getPositioningMode()).toBe('relative')
+
+            slicer.setPositioningMode('ABSOLUTE')
+            expect(slicer.getPositioningMode()).toBe('absolute')
+
         test 'should set and get extruder mode', ->
 
             expect(slicer.getExtruderMode()).toBe('absolute') # default.
@@ -787,6 +818,63 @@ describe 'Accessors (Getters and Setters)', ->
             slicer.setExtruderMode('invalid')
             expect(slicer.getExtruderMode()).toBe('absolute') # unchanged.
 
+            # Should accept any capitalization.
+            slicer.setExtruderMode('Relative')
+            expect(slicer.getExtruderMode()).toBe('relative')
+
+            slicer.setExtruderMode('ABSOLUTE')
+            expect(slicer.getExtruderMode()).toBe('absolute')
+
+        test 'should accept case-insensitive input for all string setters', ->
+
+            # Each string setter must accept any capitalization and store the canonical form.
+            # This prevents silent failures caused by toLowerCase() vs camelCase mismatch.
+
+            slicer.setWorkspacePlane('xy')
+            expect(slicer.getWorkspacePlane()).toBe('XY')
+
+            slicer.setTimeUnit('SECONDS')
+            expect(slicer.getTimeUnit()).toBe('seconds')
+
+            slicer.setLengthUnit('INCHES')
+            expect(slicer.getLengthUnit()).toBe('inches')
+
+            slicer.setSpeedUnit('MILLIMETERSECOND')
+            expect(slicer.getSpeedUnit()).toBe('millimeterSecond')
+
+            slicer.setTemperatureUnit('FAHRENHEIT')
+            expect(slicer.getTemperatureUnit()).toBe('fahrenheit')
+
+            slicer.setAngleUnit('RADIAN')
+            expect(slicer.getAngleUnit()).toBe('radian')
+
+            slicer.setInfillPattern('GRID')
+            expect(slicer.getInfillPattern()).toBe('grid')
+
+            slicer.setInfillPatternCentering('GLOBAL')
+            expect(slicer.getInfillPatternCentering()).toBe('global')
+
+            slicer.setSupportType('NORMAL')
+            expect(slicer.getSupportType()).toBe('normal')
+
+            slicer.setSupportPlacement('EVERYWHERE')
+            expect(slicer.getSupportPlacement()).toBe('everywhere')
+
+            slicer.setSupportPlacement('BUILDPLATE')
+            expect(slicer.getSupportPlacement()).toBe('buildPlate')
+
+            slicer.setAdhesionType('BRIM')
+            expect(slicer.getAdhesionType()).toBe('brim')
+
+            slicer.setSkirtType('CIRCULAR')
+            expect(slicer.getSkirtType()).toBe('circular')
+
+            slicer.setPositioningMode('RELATIVE')
+            expect(slicer.getPositioningMode()).toBe('relative')
+
+            slicer.setExtruderMode('RELATIVE')
+            expect(slicer.getExtruderMode()).toBe('relative')
+
     describe 'Configuration Object Accessors', ->
 
         Printer = require('../config/printer/printer')
