CLOUD-1461 HttpConnections not being released when using KubePing

The handler did not close the HttpExchange, which lead to HttpConnections not being removed from a Set in ServerImpl. With this commit, it is now closed properly. A proper HTTP response has also been added.

Author: luksa

common/src/main/java/org/openshift/ping/common/server/JBossServer.java

@@ -30,6 +30,8 @@
  * @author <a href="mailto:[email protected]">Ales Justin</a>
  */
 public class JBossServer extends AbstractServer {
+    private static final byte[] RESPONSE_BYTES = "OK".getBytes();
+
     private HttpServer server;
 
     public JBossServer(int port) {
@@ -77,15 +79,20 @@ private Handler(Server server) {
         }
 
         public void handle(HttpExchange exchange) throws IOException {
-            exchange.sendResponseHeaders(200, 0);
             try {
-                String clusterName = exchange.getRequestHeaders().getFirst(CLUSTER_NAME);
-                Channel channel = server.getChannel(clusterName);
-                try (InputStream stream = exchange.getRequestBody()) {
-                    handlePingRequest(channel, stream);
+                try {
+                    String clusterName = exchange.getRequestHeaders().getFirst(CLUSTER_NAME);
+                    Channel channel = server.getChannel(clusterName);
+                    try (InputStream stream = exchange.getRequestBody()) {
+                        handlePingRequest(channel, stream);
+                    }
+                    exchange.sendResponseHeaders(200, RESPONSE_BYTES.length);
+                    exchange.getResponseBody().write(RESPONSE_BYTES);
+                } catch (Exception e) {
+                    throw new IOException(e);
                 }
-            } catch (Exception e) {
-                throw new IOException(e);
+            } finally {
+                exchange.close();
             }
         }
     }