Add a test for parsing wrong labels

Author: slaskawi

kube/src/test/java/org/jgroups/ping/kube/test/ClientTest.java

@@ -53,7 +53,7 @@ public void testPods() throws Exception {
     @Test
     public void testParsingPortWithoutNames() throws Exception {
         //given
-        Client client = new TestClient("/pods_without_ports.json", 8888);
+        Client client = new TestClient("pods_without_ports.json", 8888);
 
         //when
         long numberOfPods = client.getPods(null, null).stream()
@@ -64,6 +64,18 @@ public void testParsingPortWithoutNames() throws Exception {
         assertEquals(2, numberOfPods);
     }
 
+    @Test
+    public void testParsingJSONWithWrongLabels() throws Exception {
+        //given
+        Client client = new TestClient("pods_with_wrong_labels.json", 8888);
+
+        //when
+        long numberOfPods = client.getPods("doesn't matter", "doesn't matter").size();
+
+        //then
+        assertEquals(0, numberOfPods);
+    }
+
     @Test
     public void testAcceptingProperPort() throws Exception {
         //given

kube/src/test/java/org/jgroups/ping/kube/test/TestClient.java

@@ -16,13 +16,9 @@
 
 package org.jgroups.ping.kube.test;
 
-import static org.jgroups.ping.common.Utils.readFileToString;
-
-import java.io.File;
 import java.io.IOException;
+import java.io.InputStream;
 import java.net.URISyntaxException;
-import java.util.HashMap;
-import java.util.Map;
 
 import org.jboss.dmr.ModelNode;
 import org.jgroups.ping.kube.Client;
@@ -31,28 +27,26 @@
  * @author <a href="mailto:[email protected]">Ales Justin</a>
  */
 public class TestClient extends Client {
-    private final Map<String, String> OPS = new HashMap<>();
+
+    private final String file;
 
     public TestClient() throws URISyntaxException, IOException {
         this(8888);
     }
 
     public TestClient(int port) throws URISyntaxException, IOException {
-        this("/pods.json", port);
+        this("pods.json", port);
     }
 
     public TestClient(String jsonFile, int port) throws URISyntaxException, IOException {
         super(null, null, 0, 0, 0, 0, null, port);
-        String json = readFileToString(new File(TestClient.class.getResource(jsonFile).toURI()));
-        OPS.put("pods", json);
+        file = jsonFile;
     }
 
     @Override
     protected ModelNode getNode(String op, String namespace, String labels) throws Exception {
-        String value = OPS.get(op);
-        if (value == null) {
-            throw new IllegalStateException("No such op: " + op);
+        try (InputStream stream = this.getClass().getClassLoader().getResourceAsStream(file)) {
+            return ModelNode.fromJSONStream(stream);
         }
-        return ModelNode.fromJSONString(value);
     }
 }

kube/src/test/resources/pods_with_wrong_labels.json

@@ -0,0 +1,6 @@
+{
+  "kind": "PodList",
+  "apiVersion": "v1",
+  "resourceVersion":"1524",
+  "items": []
+}