Merge pull request #70 from 4fath/master

Cleaning at Test Code

Author: belaban

src/test/java/org/jgroups/ping/kube/test/ClientTest.java

@@ -31,7 +31,7 @@ public void testParsingPortWithoutNames() throws Exception {
         Client client = new TestClient("/pods_without_ports.json");
 
         //when
-        long numberOfPods =(long)client.getPods(null, null, false).size();
+        int numberOfPods = client.getPods(null, null, false).size();
 
         //then
         assertEquals(2, numberOfPods);

src/test/java/org/jgroups/ping/kube/test/JsonTest.java

@@ -7,6 +7,7 @@
 import java.util.List;
 
 import static org.jgroups.protocols.kubernetes.Utils.readFileToString;
+import static org.junit.Assert.assertEquals;
 
 /**
  * @author Bela Ban
@@ -27,6 +28,7 @@ public void testJsonParser() throws Exception {
             Json phase=status.at("phase");
             Json ip=status.at("podIP");
             System.out.printf("%s -> %s\n", ip, phase);
+            assertEquals("Running", phase.asString());
         }
 
         /* JsonObject root=JsonParser.object().from(input);

src/test/java/org/jgroups/ping/kube/test/RollingUpdateTest.java

@@ -86,7 +86,7 @@ static class KUBE_PING_FOR_TESTING extends KUBE_PING {
       private final List<Message> collectedMessages = new ArrayList<>();
       private List<Pod> pods;
 
-      public KUBE_PING_FOR_TESTING(String resourceFile) {
+      KUBE_PING_FOR_TESTING(String resourceFile) {
          this.resourceFile = resourceFile;
       }
 
@@ -102,11 +102,11 @@ protected void sendDiscoveryRequest(Message req) {
          collectedMessages.add(req);
       }
 
-      public List<Message> getCollectedMessages() {
+      List<Message> getCollectedMessages() {
          return collectedMessages;
       }
 
-      public List<Pod> getPods() {
+      List<Pod> getPods() {
          return pods;
       }
    }

src/test/java/org/jgroups/ping/kube/test/util/FreePortFinder.java

@@ -4,7 +4,9 @@
 
 public class FreePortFinder {
 
-   public static int DEFAULT_PORT = 13256;
+   private static final int DEFAULT_PORT = 13256;
+
+   private FreePortFinder() { }
 
    public static int findFreePort() {
       try (ServerSocket socket = new ServerSocket(0)) {