Couple fixes (zarr-developers#1737)

DimitriPapadopoulos · web-flow · commit aa9a0d5e1874 · 2024-04-02T23:15:48.000+05:30
* Use `is` when comparing `type` of two objects

* Unnecessary `None` provided as default
diff --git a/zarr/_storage/store.py b/zarr/_storage/store.py
@@ -462,7 +462,7 @@ def inner_store(self) -> Union["StorageTransformer", StoreV3]:
 
     def __eq__(self, other):
         return (
-            type(self) == type(other)
+            type(self) is type(other)
             and self._inner_store == other._inner_store
             and self.get_config() == other.get_config()
         )
diff --git a/zarr/tests/test_core.py b/zarr/tests/test_core.py
@@ -123,7 +123,7 @@ def create_array(self, shape: Union[int, Tuple[int, ...]], **kwargs):
             "compressor": kwargs.pop("compressor", self.compressor),
             "chunk_store": chunk_store,
             "storage_transformers": self.create_storage_transformers(shape),
-            "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype", None))),
+            "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype"))),
         }
 
         # keyword arguments for array instantiation

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ def inner_store(self) -> Union["StorageTransformer", StoreV3]:`
`462`	`462`
`463`	`463`	`def __eq__(self, other):`
`464`	`464`	`return (`
`465`		`- type(self) == type(other)`
	`465`	`+ type(self) is type(other)`
`466`	`466`	`and self._inner_store == other._inner_store`
`467`	`467`	`and self.get_config() == other.get_config()`
`468`	`468`	`)`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ def create_array(self, shape: Union[int, Tuple[int, ...]], **kwargs):`
`123`	`123`	`"compressor": kwargs.pop("compressor", self.compressor),`
`124`	`124`	`"chunk_store": chunk_store,`
`125`	`125`	`"storage_transformers": self.create_storage_transformers(shape),`
`126`		`- "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype", None))),`
	`126`	`+ "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype"))),`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`# keyword arguments for array instantiation`