fix: break nested ternaries together

Author: jtkiesel

packages/prettier-plugin-java/src/printers/expressions.ts

@@ -116,18 +116,21 @@ export default {
 
   conditionalExpression(path, print) {
     const binaryExpression = call(path, print, "binaryExpression");
+    if (!path.node.children.QuestionMark) {
+      return binaryExpression;
+    }
     const expressions = map(path, print, "expression");
-    return path.node.children.QuestionMark
-      ? group(
-          indent(
-            join(line, [
-              binaryExpression,
-              ["? ", expressions[0]],
-              [": ", expressions[1]]
-            ])
-          )
-        )
-      : binaryExpression;
+    const contents = indent(
+      join(line, [
+        binaryExpression,
+        ["? ", expressions[0]],
+        [": ", expressions[1]]
+      ])
+    );
+    const isNestedTernary =
+      (path.getNode(4) as JavaNonTerminal | null)?.name ===
+      "conditionalExpression";
+    return isNestedTernary ? contents : group(contents);
   },
 
   binaryExpression(path, print, options) {

packages/prettier-plugin-java/test/unit-test/binary_expressions/operator-position-end/_input.java

@@ -32,6 +32,10 @@ public int ternaryOperationThatShouldNotBreak() {
     return b ? b : c;
   }
 
+  void nestedTernary() {
+    aaaaaaaaaa ? bbbbbbbbbb : cccccccccc ? dddddddddd : eeeeeeeeee ? ffffffffff : gggggggggg;
+  }
+
   public boolean binaryOperationWithComments() {
     boolean a = one || two >> 1 // one
       // two

packages/prettier-plugin-java/test/unit-test/binary_expressions/operator-position-end/_output.java

@@ -49,6 +49,16 @@ public int ternaryOperationThatShouldNotBreak() {
     return b ? b : c;
   }
 
+  void nestedTernary() {
+    aaaaaaaaaa
+      ? bbbbbbbbbb
+      : cccccccccc
+        ? dddddddddd
+        : eeeeeeeeee
+          ? ffffffffff
+          : gggggggggg;
+  }
+
   public boolean binaryOperationWithComments() {
     boolean a =
       one ||

packages/prettier-plugin-java/test/unit-test/binary_expressions/operator-position-start/_input.java

@@ -32,6 +32,10 @@ public int ternaryOperationThatShouldNotBreak() {
     return b ? b : c;
   }
 
+  void nestedTernary() {
+    aaaaaaaaaa ? bbbbbbbbbb : cccccccccc ? dddddddddd : eeeeeeeeee ? ffffffffff : gggggggggg;
+  }
+
   public boolean binaryOperationWithComments() {
     boolean a = one || two >> 1 // one
       // two

packages/prettier-plugin-java/test/unit-test/binary_expressions/operator-position-start/_output.java

@@ -49,6 +49,16 @@ public int ternaryOperationThatShouldNotBreak() {
     return b ? b : c;
   }
 
+  void nestedTernary() {
+    aaaaaaaaaa
+      ? bbbbbbbbbb
+      : cccccccccc
+        ? dddddddddd
+        : eeeeeeeeee
+          ? ffffffffff
+          : gggggggggg;
+  }
+
   public boolean binaryOperationWithComments() {
     boolean a =
       one