Skip to content

Commit a90cfa3

Browse files
motlinjtkiesel
authored andcommitted
Fix update-test-outputs script to use test-specific prettier options.
1 parent d7f643d commit a90cfa3

File tree

9 files changed

+37
-13
lines changed

9 files changed

+37
-13
lines changed

packages/prettier-plugin-java/scripts/update-test-output.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,20 @@ const updateTestOutput = async () => {
5151
try {
5252
console.log(`Reading <${fileDesc.path}>`);
5353
let newExpectedText = javaFileText;
54+
55+
const testDir = path.dirname(fileDesc.path);
56+
const optionsPath = path.join(testDir, ".prettierrc.json");
57+
const testOptions = fs.existsSync(optionsPath)
58+
? fs.readJsonSync(optionsPath)
59+
: {};
60+
5461
for (let i = 0; i < numberOfTime; i++) {
5562
newExpectedText = await prettier.format(newExpectedText, {
5663
parser: "java",
5764
plugins: [path.resolve(__dirname, "../dist/index.js")],
5865
tabWidth: 2,
59-
endOfLine: "lf"
66+
endOfLine: "lf",
67+
...testOptions
6068
});
6169
}
6270
let outputFilePath = fileDesc.path.replace(

packages/prettier-plugin-java/test/test-utils.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@ const { readFileSync, existsSync, removeSync, copySync } = fs;
1414
const __dirname = dirname(url.fileURLToPath(import.meta.url));
1515
export function testSampleWithOptions({
1616
testFolder,
17-
exclusive,
18-
prettierOptions = {}
17+
exclusive
1918
}: {
2019
testFolder: string;
2120
exclusive?: boolean;
22-
prettierOptions?: any;
2321
}) {
2422
const itOrItOnly = exclusive ? it.only : it;
2523
const inputPath = resolve(testFolder, "_input.java");
@@ -29,6 +27,11 @@ export function testSampleWithOptions({
2927
let inputContents: string;
3028
let expectedContents: string;
3129

30+
const prettierrcPath = resolve(testFolder, ".prettierrc.json");
31+
const prettierOptions = existsSync(prettierrcPath)
32+
? fs.readJsonSync(prettierrcPath)
33+
: {};
34+
3235
// @ts-ignore
3336
before(() => {
3437
inputContents = readFileSync(inputPath, "utf8");

packages/prettier-plugin-java/test/unit-test/binary_expressions/binary_expressions-spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
66

77
describe("prettier-java", () => {
88
testSampleWithOptions({
9-
testFolder: path.resolve(__dirname, "operator-position-start"),
10-
prettierOptions: { experimentalOperatorPosition: "start" }
9+
testFolder: path.resolve(__dirname, "operator-position-start")
1110
});
11+
1212
testSampleWithOptions({
13-
testFolder: path.resolve(__dirname, "operator-position-end"),
14-
prettierOptions: { experimentalOperatorPosition: "end" }
13+
testFolder: path.resolve(__dirname, "operator-position-end")
1514
});
1615
testSample(path.resolve(__dirname, "operator-position-end"));
1716
});
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"experimentalOperatorPosition": "end"
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"experimentalOperatorPosition": "start"
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"requirePragma": true
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"requirePragma": true
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"requirePragma": true
3+
}

packages/prettier-plugin-java/test/unit-test/require-pragma/require-pragma-spec.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ describe("prettier-java: require-pragma option", () => {
99
path.resolve(__dirname, "./format-pragma"),
1010
path.resolve(__dirname, "./prettier-pragma"),
1111
path.resolve(__dirname, "./invalid-pragma")
12-
].forEach(testFolder =>
12+
].forEach(testFolder => {
1313
testSampleWithOptions({
14-
testFolder,
15-
prettierOptions: { requirePragma: true }
16-
})
17-
);
14+
testFolder
15+
});
16+
});
1817
});

0 commit comments

Comments
 (0)