Skip to content

Commit 46c440b

Browse files
committed
fix: address PR review comments for codex parser
1 parent f0d7d11 commit 46c440b

File tree

2 files changed

+39
-2
lines changed

2 files changed

+39
-2
lines changed

src-tauri/src/providers/codex.rs

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1633,6 +1633,23 @@ mod tests {
16331633
);
16341634
}
16351635

1636+
#[test]
1637+
fn convert_agent_reasoning_event_skips_empty_text() {
1638+
let mut counter = 0u64;
1639+
let msg = convert_codex_event(
1640+
&json!({
1641+
"type": "agent_reasoning",
1642+
"text": " "
1643+
}),
1644+
"session-1",
1645+
"2026-02-19T12:00:00Z",
1646+
&mut counter,
1647+
);
1648+
1649+
assert!(msg.is_none());
1650+
assert_eq!(counter, 0);
1651+
}
1652+
16361653
#[test]
16371654
fn convert_agent_message_event_to_assistant_text_message() {
16381655
let mut counter = 0u64;
@@ -1660,6 +1677,22 @@ mod tests {
16601677
);
16611678
}
16621679

1680+
#[test]
1681+
fn convert_agent_message_event_skips_missing_field() {
1682+
let mut counter = 0u64;
1683+
let msg = convert_codex_event(
1684+
&json!({
1685+
"type": "agent_message"
1686+
}),
1687+
"session-1",
1688+
"2026-02-19T12:00:00Z",
1689+
&mut counter,
1690+
);
1691+
1692+
assert!(msg.is_none());
1693+
assert_eq!(counter, 0);
1694+
}
1695+
16631696
#[test]
16641697
fn convert_user_message_event_to_user_text_message() {
16651698
let mut counter = 0u64;

src/components/MessageViewer/components/ClaudeMessageNode.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,11 @@ export const ClaudeMessageNode = React.memo(({
196196
}
197197

198198
// File history snapshot messages
199-
if (message.type === "file-history-snapshot" && message.snapshot) {
199+
if (message.type === "file-history-snapshot") {
200+
if (!message.snapshot) {
201+
return null;
202+
}
203+
200204
return (
201205
<div
202206
data-message-uuid={message.uuid}
@@ -208,7 +212,7 @@ export const ClaudeMessageNode = React.memo(({
208212
{CaptureHideButton}
209213
<div className="max-w-4xl mx-auto">
210214
<FileHistorySnapshotRenderer
211-
messageId={message.messageId ?? ""}
215+
messageId={message.messageId ?? message.uuid}
212216
snapshot={message.snapshot}
213217
isSnapshotUpdate={Boolean(message.isSnapshotUpdate)}
214218
/>

0 commit comments

Comments
 (0)